1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B425B429E26
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:40 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 24WSUe3CdThO for <notmuch@notmuchmail.org>;
\r
17 Tue, 13 Dec 2011 09:49:40 -0800 (PST)
\r
18 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
19 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
20 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
21 0B0F2429E25 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:39 -0800
\r
23 Received: by wgbds13 with SMTP id ds13so11326375wgb.2
\r
24 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 09:49:37 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=RcFPd1yQ+M3fnBK0uvdSUvCqOxzHUKYGszLOKxyeX/I=;
\r
29 b=BAOBCmCkfMKWPts4ttff2tuXJuaal+8rSqWWNkjNuwnTonVGxSs71MAXdjkw1QqAJ8
\r
30 9U7Z3QBO6d6zG2MJGleYcHLjUbaOcDCm4SGdXgenNaK/01IeXJoLVSNKPbe8mMLpmhPc
\r
31 Tz0YnRhW+sP9ldl8AhAAsLJYOGmOzAyK+lAmE=
\r
32 Received: by 10.227.199.78 with SMTP id er14mr17305616wbb.10.1323798577432;
\r
33 Tue, 13 Dec 2011 09:49:37 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id em4sm27495171wbb.20.2011.12.13.09.49.36
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 13 Dec 2011 09:49:36 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v3 4/4] emacs: add notmuch-hello-hook
\r
41 In-Reply-To: <1323797532-597-5-git-send-email-schnouki@schnouki.net>
\r
42 References: <87d3cx2t38.fsf@rocinante.cs.unb.ca>
\r
43 <1323797532-597-1-git-send-email-schnouki@schnouki.net>
\r
44 <1323797532-597-5-git-send-email-schnouki@schnouki.net>
\r
45 User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Tue, 13 Dec 2011 21:49:00 +0400
\r
48 Message-ID: <87zkewuzub.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Tue, 13 Dec 2011 17:49:40 -0000
\r
65 On Tue, 13 Dec 2011 18:32:12 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
\r
66 > This hook is called every time the notmuch-hello buffer is updated.
\r
68 > emacs/notmuch-hello.el | 9 ++++++++-
\r
69 > 1 files changed, 8 insertions(+), 1 deletions(-)
\r
71 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
72 > index 0fe9c1d..112b40b 100644
\r
73 > --- a/emacs/notmuch-hello.el
\r
74 > +++ b/emacs/notmuch-hello.el
\r
75 > @@ -131,6 +131,11 @@ So:
\r
76 > (integer :tag "Number of characters")
\r
77 > (float :tag "Fraction of window")))
\r
79 > +(defcustom notmuch-hello-hook nil
\r
80 > + "Functions called after populating a `notmuch-hello' buffer."
\r
82 > + :group 'notmuch)
\r
84 > (defcustom notmuch-thousands-separator ","
\r
85 > "The string used as a thousands separator.
\r
87 > @@ -579,7 +584,9 @@ Complete list of currently available key bindings:
\r
88 > (widget-forward 1)))
\r
90 > (unless (widget-at)
\r
91 > - (notmuch-hello-goto-search)))))
\r
92 > + (notmuch-hello-goto-search))
\r
94 > + (run-hooks 'notmuch-hello-hook))))
\r
97 I spent some time finding out why run-hooks are not on the top level.
\r
98 Turns out it is inside two let statements. Can we move to the top level
\r
99 of `notmuch-hello' to make it clear that it is always run (i.e. there
\r
100 are no ifs or whens)?
\r
102 BTW this would replace one of the oldest custom patches which I have in
\r
103 my master branch :)
\r
108 > (defun notmuch-folder ()
\r
109 > "Deprecated function for invoking notmuch---calling `notmuch' is preferred now."
\r
113 > _______________________________________________
\r
114 > notmuch mailing list
\r
115 > notmuch@notmuchmail.org
\r
116 > http://notmuchmail.org/mailman/listinfo/notmuch
\r