1 Return-Path: <cceleri@cs.stanford.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CD36A431FBD
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 May 2014 02:40:24 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id PlBbEJSeoQ0s for <notmuch@notmuchmail.org>;
\r
16 Tue, 13 May 2014 02:40:17 -0700 (PDT)
\r
17 Received: from smtp3.cs.Stanford.EDU (smtp3.cs.Stanford.EDU [171.64.64.27])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 8CEEE431FAF
\r
21 for <notmuch@notmuchmail.org>; Tue, 13 May 2014 02:40:17 -0700 (PDT)
\r
22 Received: from cs-tor.bu.edu ([204.8.156.142] helo=jane.lan)
\r
23 by smtp3.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)
\r
24 (Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)
\r
25 id 1Wk9C0-00023j-69; Tue, 13 May 2014 02:40:13 -0700
\r
26 From: Charles Celerier <cceleri@cs.stanford.edu>
\r
27 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
28 Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with
\r
30 In-Reply-To: <877g5rgrqy.fsf@maritornes.cs.unb.ca>
\r
31 References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>
\r
32 <87d2fjgtcr.fsf@maritornes.cs.unb.ca>
\r
33 <877g5rgrqy.fsf@maritornes.cs.unb.ca>
\r
34 User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-apple-darwin13.1.0)
\r
36 Date: Tue, 13 May 2014 05:40:04 -0400
\r
37 Message-ID: <m2y4y610gb.fsf@jane.lan>
\r
39 Content-Type: multipart/signed; boundary="=-=-=";
\r
40 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
41 X-Scan-Signature: 127ff6e1eac6b45a32dc112250ed777d
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Tue, 13 May 2014 09:40:24 -0000
\r
57 Content-Type: text/plain
\r
59 David Bremner <david@tethera.net> writes:
\r
61 > David Bremner <david@tethera.net> writes:
\r
63 >> Originally I thought this was uneccesarily intrusive, but on a second
\r
64 >> look I see that there is only one symbol changed that doesn't start with
\r
65 >> _notmuch, so I guess for consistency it's fine.
\r
67 Actually, they all start with _notmuch. The symbol
\r
68 _thread_add_matched_author is not changed.
\r
70 >> I'm thinking about a 0.18.1 point release for build and portability
\r
71 >> fixes; I do think this is a bit too much change for that (especially
\r
72 >> since it doesn't actually fix the symbol hiding test (or more precisely,
\r
73 >> your fix for OS/X breaks the linux test).
\r
77 > Also, I'd like a less confusing commit message. Do you understand the
\r
78 > situation enough to write one now? In particular it's just a convention
\r
79 > that private symbols should not start with "notmuch", and the actual
\r
80 > hiding happens elsewhere.
\r
84 Yes, I now understand the hiding happens elsewhere. There is a note in
\r
85 devel/STYLE in the "libnotmuch conventions" section that discusses the
\r
86 use of underscores to denote private library functions; I will cite
\r
87 that as the reason for the patch instead.
\r
92 Content-Type: application/pgp-signature
\r
94 -----BEGIN PGP SIGNATURE-----
\r
95 Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
\r
97 iQEcBAEBAgAGBQJTceh0AAoJEOjk698fDjuAXHoIAJLE+SmTzjZVFoqeUaKNXml3
\r
98 UlIq3h+q6lcW6J8ev+ni/qPHkaK+945GSad1BdaILLfgzJJT85/5ZxVo5JRb6Eex
\r
99 XIeqNy/WBGJiqJGr7vkoAoQb0T6aUUEOtV6q9qUBansWVYTUGgaMZQe9SXBWkaf1
\r
100 SXSWHxhY+MAjd8TmMyzvLKWbXjO53VYrYUQm9X2b1PidHGi9SYAzs2DXe+Yv9gID
\r
101 owg7uZtilUTVEQT7OU79tlU9CjX0AYfJQWC79uznyGzzU3e235ZVPdHBAK8s4Len
\r
102 zBPC6d/mArWsdBt6J0585E2RvJMkIq/wwesTnvggR7V4orZfx7f/c4G3lL1iTSA=
\r
104 -----END PGP SIGNATURE-----
\r