1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B9C4F431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 9 Nov 2012 00:55:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id JMmUxet-W6UF for <notmuch@notmuchmail.org>;
\r
16 Fri, 9 Nov 2012 00:55:56 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id E576E431FAE
\r
19 for <notmuch@notmuchmail.org>; Fri, 9 Nov 2012 00:55:55 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 98B89100094;
\r
22 Fri, 9 Nov 2012 10:55:54 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message
\r
27 In-Reply-To: <87ehk332la.fsf@zancas.localnet>
\r
28 References: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>
\r
29 <87ehk332la.fsf@zancas.localnet>
\r
30 User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Fri, 09 Nov 2012 10:55:54 +0200
\r
36 Message-ID: <m2fw4jqhnp.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Fri, 09 Nov 2012 08:55:58 -0000
\r
53 On Fri, Nov 09 2012, David Bremner <david@tethera.net> wrote:
\r
55 > Mark Walters <markwalters1009@gmail.com> writes:
\r
57 >> - (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
\r
58 >> + (let ((id (notmuch-pick-get-prop :id)))
\r
60 >> + (concat "id:\"" id "\""))))
\r
62 > I don't know how other people feel, but I'd rather have an `if' in a
\r
63 > context where I care about the return value.
\r
65 Does (when COND BODY) connotate to the thought that the return value
\r
66 is generally not used ? That expands to (if COND (progn BODY)) so both
\r
67 returns exactly same values.
\r
69 (not that I wouldn't prefer if there :)
\r
71 But instead of this the function in question could use
\r
72 recently introduced (notmuch-id-to-query id) instead.
\r