1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8FE61431FC0
\r
6 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 05:55:15 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id mlNKwC8iiedZ for <notmuch@notmuchmail.org>;
\r
16 Mon, 24 Sep 2012 05:55:14 -0700 (PDT)
\r
17 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id B8EA4431FAF
\r
21 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 05:55:14 -0700 (PDT)
\r
22 Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])
\r
23 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
24 (No client certificate requested)
\r
25 by mail.cryptobitch.de (Postfix) with ESMTPSA id 88A7C5AB202
\r
26 for <notmuch@notmuchmail.org>; Mon, 24 Sep 2012 14:55:13 +0200 (CEST)
\r
27 Received: by mail.jade-hamburg.de (Postfix, from userid 401)
\r
28 id F2819DF2A3; Mon, 24 Sep 2012 14:55:12 +0200 (CEST)
\r
29 Received: from thinkbox.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])
\r
30 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
31 (No client certificate requested) (Authenticated sender: teythoon)
\r
32 by mail.jade-hamburg.de (Postfix) with ESMTPSA id F3FFDDF2A1;
\r
33 Mon, 24 Sep 2012 14:55:11 +0200 (CEST)
\r
34 Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80)
\r
35 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
36 id 1TG8Bq-0003kp-SR; Mon, 24 Sep 2012 14:55:10 +0200
\r
37 Content-Type: text/plain; charset="utf-8"
\r
39 Content-Transfer-Encoding: quoted-printable
\r
40 To: Austin Clements <amdragon@MIT.EDU>,
\r
41 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
42 In-Reply-To: <20120922161908.GF26662@mit.edu>
\r
44 <1348231837-21700-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
45 <1348231837-21700-2-git-send-email-4winter@informatik.uni-hamburg.de>
\r
46 <20120922161908.GF26662@mit.edu>
\r
47 Message-ID: <20120924125510.13910.18774@thinkbox.jade-hamburg.de>
\r
48 User-Agent: alot/0.3.3+
\r
49 Subject: Re: [PATCH 2/2] Avoid potentially dereferencing a NULL pointer
\r
50 Date: Mon, 24 Sep 2012 14:55:10 +0200
\r
51 Cc: notmuch@notmuchmail.org
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Mon, 24 Sep 2012 12:55:15 -0000
\r
66 Quoting Austin Clements (2012-09-22 18:19:08)
\r
67 > Quoth Justus Winter on Sep 21 at 2:50 pm:
\r
68 > > GMIME_IS_MULTIPART and GMIME_IS_MESSAGE both handle NULL pointers
\r
69 > > gracefully, but the G_OBJECT_TYPE used in the error handling block
\r
70 > > dereferences it without checking it first.
\r
73 > > Fix this by checking whether parent->part is valid.
\r
76 > > Found using the clang static analyzer.
\r
81 Yes. Besides this the code turns up no warnings (modulo one false
\r
82 positive, clang doesn't understand that progress_notify is never
\r
83 called if it's NULL in notmuch_database_upgrade b/c the signal handler
\r
86 > Can this actually happen, though? If so, I think this point is too
\r
87 > late to be checking for a NULL part field. It should probably be
\r
88 > checked when the mime_node_t is created so that mime_node_t never has
\r
89 > a NULL part field.
\r
91 I'm not sure actually. Then again this patch isn't hacky at all and
\r
92 being somewhat defensive isn't bad imho.
\r