1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6341F431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 6 Dec 2012 14:35:39 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id nDkv4cGqqt0T for <notmuch@notmuchmail.org>;
\r
17 Thu, 6 Dec 2012 14:35:36 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E768A431FAE
\r
22 for <notmuch@notmuchmail.org>; Thu, 6 Dec 2012 14:35:35 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Tgk2Y-0003A2-1L; Thu, 06 Dec 2012 22:35:34 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Tgk2X-0007bZ-NV; Thu, 06 Dec 2012 22:35:33 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] emacs: add support for stashing the thread id in show
\r
35 In-Reply-To: <1354827443-10549-1-git-send-email-jani@nikula.org>
\r
36 References: <1354827443-10549-1-git-send-email-jani@nikula.org>
\r
37 User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Thu, 06 Dec 2012 22:35:37 +0000
\r
40 Message-ID: <87mwxqhkqu.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 93.97.24.31
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: 2d8b9fbec95b84747639e893bbb93984 (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: -1.7
\r
47 X-SpamAssassin-SpamBar: -
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored -1.7 points.
\r
52 Summary of the scoring:
\r
53 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
55 * [138.37.6.40 listed in list.dnswl.org]
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * 0.6 AWL AWL: From: address is in the auto white-list
\r
59 X-QM-Scan-Virus: ClamAV says the message is clean
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Thu, 06 Dec 2012 22:35:39 -0000
\r
75 On Thu, 06 Dec 2012, Jani Nikula <jani@nikula.org> wrote:
\r
76 > Add a prefix argument to notmuch-show-stash-message-id to stash thread
\r
77 > id instead of message id.
\r
79 > emacs/notmuch-show.el | 13 +++++++++----
\r
80 > 1 file changed, 9 insertions(+), 4 deletions(-)
\r
82 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
83 > index 4d6c014..2245b4f 100644
\r
84 > --- a/emacs/notmuch-show.el
\r
85 > +++ b/emacs/notmuch-show.el
\r
86 > @@ -1901,10 +1901,15 @@ thread from search."
\r
88 > (notmuch-common-do-stash (notmuch-show-get-from)))
\r
90 > -(defun notmuch-show-stash-message-id ()
\r
91 > - "Copy id: query matching the current message to kill-ring."
\r
93 > - (notmuch-common-do-stash (notmuch-show-get-message-id)))
\r
94 > +(defun notmuch-show-stash-message-id (&optional thread-id)
\r
95 > + "Copy id: query matching the current message to kill-ring.
\r
97 > +If invoked with a prefix argument (or THREAD-ID is non-nil), copy
\r
98 > +thread: query matching the current thread to kill-ring."
\r
99 > + (interactive "P")
\r
101 > + (notmuch-common-do-stash notmuch-show-thread-id)
\r
102 > + (notmuch-common-do-stash (notmuch-show-get-message-id))))
\r
105 Basically this looks good to me. My one criticism is the name of the
\r
106 argument: thread-id looks like it should be umm, a thread-id. Maybe
\r
107 thread-id-wanted or something?
\r
114 > (defun notmuch-show-stash-message-id-stripped ()
\r
115 > "Copy message ID of current message (sans `id:' prefix) to kill-ring."
\r
119 > _______________________________________________
\r
120 > notmuch mailing list
\r
121 > notmuch@notmuchmail.org
\r
122 > http://notmuchmail.org/mailman/listinfo/notmuch
\r