1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E7FEE431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:45:40 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id vmKAkfHUazJR for <notmuch@notmuchmail.org>;
\r
16 Wed, 11 Jan 2012 00:45:40 -0800 (PST)
\r
17 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com
\r
18 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 5A07C431FB6
\r
21 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:45:40 -0800 (PST)
\r
22 Received: by qcpx40 with SMTP id x40so21974qcp.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 00:45:39 -0800 (PST)
\r
24 Received: by 10.224.52.75 with SMTP id h11mr29383168qag.46.1326271539668;
\r
25 Wed, 11 Jan 2012 00:45:39 -0800 (PST)
\r
26 Received: from localhost (nikula.org. [92.243.24.172])
\r
27 by mx.google.com with ESMTPS id hv20sm2273214qab.22.2012.01.11.00.45.37
\r
28 (version=SSLv3 cipher=OTHER); Wed, 11 Jan 2012 00:45:38 -0800 (PST)
\r
29 From: Jani Nikula <jani@nikula.org>
\r
30 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
31 Subject: Re: [PATCH v3 2/4] emacs: add support for replying just to the sender
\r
32 In-Reply-To: <cun39bmodjr.fsf@hotblack-desiato.hh.sledj.net>
\r
33 References: <cover.1326224339.git.jani@nikula.org>
\r
34 <069a0cddd4e848314fb64da861b3bf5b4f053f14.1326224339.git.jani@nikula.org>
\r
35 <cun39bmodjr.fsf@hotblack-desiato.hh.sledj.net>
\r
36 User-Agent: Notmuch/0.10.2+187~g43d4f26 (http://notmuchmail.org) Emacs/23.1.1
\r
38 Date: Wed, 11 Jan 2012 08:45:35 +0000
\r
39 Message-ID: <87wr8yvd8w.fsf@nikula.org>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Wed, 11 Jan 2012 08:45:41 -0000
\r
56 On Wed, 11 Jan 2012 08:20:56 +0000, David Edmondson <dme@dme.org> wrote:
\r
57 > On Tue, 10 Jan 2012 21:54:02 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
58 > > Provide reply to sender counterparts to the search and show reply
\r
59 > > functions. Add key binding 'R' to reply to sender, while keeping 'r' as
\r
60 > > reply to all, both in search and show views.
\r
62 > All looks fine. My only comments are nits.
\r
64 > > -(defun notmuch-mua-reply (query-string &optional sender)
\r
65 > > +(defun notmuch-mua-reply (query-string &optional sender reply-all)
\r
68 > > (args '("reply")))
\r
69 > > (if notmuch-show-process-crypto
\r
70 > > (setq args (append args '("--decrypt"))))
\r
72 > > + (setq args (append args '("--reply-to=all")))
\r
73 > > + (setq args (append args '("--reply-to=sender"))))
\r
74 > > (setq args (append args (list query-string)))
\r
76 > I don't like how this ends up. How about something like:
\r
78 > (defun notmuch-mua-reply (query-string &optional sender)
\r
81 > (args (nconc (list "reply"
\r
82 > (concat "--reply-to="
\r
83 > (if reply-all "all" "sender")))
\r
84 > (when notmuch-show-process-crypto
\r
85 > (list "--decrypt"))
\r
86 > (list query-string))))
\r
88 > But even that is not very nice.
\r
90 I think the original looks better, and is easier to grasp, even if it's
\r
91 perhaps not as lispy. Besides, the last time you thought this was fine
\r
92 (id:"cunehv91e05.fsf@hotblack-desiato.hh.sledj.net"), and the patch
\r
93 hasn't changed since. ;)
\r