1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3891A431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 23:21:53 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ovV5W3NEzFhl for <notmuch@notmuchmail.org>;
\r
16 Sun, 9 Jun 2013 23:21:41 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8CAE1431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 23:21:41 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 6E745100044;
\r
22 Mon, 10 Jun 2013 09:21:29 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>,
\r
25 Mark Walters <markwalters1009@gmail.com>
\r
26 Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error
\r
27 In-Reply-To: <20130610021534.GB22196@mit.edu>
\r
28 References: <1370753138-15021-1-git-send-email-amdragon@mit.edu>
\r
29 <1370753138-15021-3-git-send-email-amdragon@mit.edu>
\r
30 <87hah7od8b.fsf@qmul.ac.uk> <20130610021534.GB22196@mit.edu>
\r
31 User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Mon, 10 Jun 2013 09:21:29 +0300
\r
37 Message-ID: <m27gi2fpue.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 Cc: notmuch@notmuchmail.org
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Mon, 10 Jun 2013 06:21:53 -0000
\r
55 On Mon, Jun 10 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
57 > Quoth Mark Walters on Jun 09 at 10:16 am:
\r
59 >> Both of these patches look good to me +1. I was able to reproduce both
\r
60 >> bugs pretty reliably (the first one always unless masked by the second
\r
61 >> one which occurred about half the time). With these patches I cannot
\r
62 >> trigger either. Also all tests pass.
\r
64 >> My only tiny concern is I couldn't find any documentation on whether the
\r
65 >> return value of the filter-function matters at all. Austin's original
\r
66 >> fix (via irc) returned t and this returns nil in the failing case (i.e.,
\r
67 >> when results-buf is dead).
\r
69 > Mm, interesting. To be fair, my choice of "t" for the original fix
\r
70 > was completely arbitrary. I think you're right that the Emacs
\r
71 > documentation doesn't have anything to say about the return values of
\r
72 > filter functions. Furthermore, the example filter functions they give
\r
73 > don't have meaningful return values, so I'm pretty sure this is safe.
\r
74 > Also the code that calls the filter discards its result.
\r
76 I also looked this a bit yesterday evening. For example this page
\r
78 http://www.gnu.org/software/emacs/manual/html_node/elisp/Filter-Functions.html
\r
80 discusses only about catching thrown errors -- i.e. no mention about
\r
81 filter function return values. From that I'd draw a conclusion that
\r
82 most probably the return value of filter function is not used for anything.
\r
84 ... and the patch looks good. +1 (removing needs-review)
\r