40/db22f14ff7cfadd814456ab3bfd37b3d6593ef

   1 Return-Path: <jrollins@finestructure.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2ACA1431FB6\r
   6         for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 14:26:59 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -2.29\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id RvM+oTAlGcYx for <notmuch@notmuchmail.org>;\r
  16         Fri,  3 Jun 2011 14:26:57 -0700 (PDT)\r
  17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
  18         [131.215.239.19])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 28C9B431FD0\r
  20         for <notmuch@notmuchmail.org>; Fri,  3 Jun 2011 14:26:57 -0700 (PDT)\r
  21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
  22         by fire-doxen-postvirus (Postfix) with ESMTP id 7DCF6328196;\r
  23         Fri,  3 Jun 2011 14:20:01 -0700 (PDT)\r
  24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
  25 Received: from servo.finestructure.net (gwave-79.ligo.caltech.edu\r
  26         [131.215.114.79]) (Authenticated sender: jrollins)\r
  27         by fire-doxen-submit (Postfix) with ESMTP id 5026A328203;\r
  28         Fri,  3 Jun 2011 14:19:58 -0700 (PDT)\r
  29 Received: by servo.finestructure.net (Postfix, from userid 1000)\r
  30         id 4FF01AD6; Fri,  3 Jun 2011 14:26:51 -0700 (PDT)\r
  31 From: Jameson Graef Rollins <jrollins@finestructure.net>\r
  32 To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
  33 Subject: Re: [PATCH 25/25] Fix stdout stream grabbing in\r
  34         format_part_content_text\r
  35 In-Reply-To: <87r57almd9.fsf@yoom.home.cworth.org>\r
  36 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>\r
  37         <1306619520-25730-2-git-send-email-jrollins@finestructure.net>\r
  38         <1306619520-25730-3-git-send-email-jrollins@finestructure.net>\r
  39         <1306619520-25730-4-git-send-email-jrollins@finestructure.net>\r
  40         <1306619520-25730-5-git-send-email-jrollins@finestructure.net>\r
  41         <1306619520-25730-6-git-send-email-jrollins@finestructure.net>\r
  42         <1306619520-25730-7-git-send-email-jrollins@finestructure.net>\r
  43         <1306619520-25730-8-git-send-email-jrollins@finestructure.net>\r
  44         <1306619520-25730-9-git-send-email-jrollins@finestructure.net>\r
  45         <1306619520-25730-10-git-send-email-jrollins@finestructure.net>\r
  46         <1306619520-25730-11-git-send-email-jrollins@finestructure.net>\r
  47         <1306619520-25730-12-git-send-email-jrollins@finestructure.net>\r
  48         <1306619520-25730-13-git-send-email-jrollins@finestructure.net>\r
  49         <1306619520-25730-14-git-send-email-jrollins@finestructure.net>\r
  50         <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
  51         <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net>\r
  52         <1306619520-25730-17-git-send-email-jrollins@finestructure.net>\r
  53         <1306619520-25730-18-git-send-email-jrollins@finestructure.net>\r
  54         <1306619520-25730-19-git-send-email-jrollins@finestructure.net>\r
  55         <1306619520-25730-20-git-send-email-jrollins@finestructure.net>\r
  56         <1306619520-25730-21-git-send-email-jrollins@finestructure.net>\r
  57         <1306619520-25730-22-git-send-email-jrollins@finestructure.net>\r
  58         <1306619520-25730-23-git-send-email-jrollins@finestructure.net>\r
  59         <1306619520-25730-24-git-send-email-jrollins@finestructure.net>\r
  60         <1306619520-25730-25-git-send-email-jrollins@finestructure.net>\r
  61         <1306619520-25730-26-git-send-email-jrollins@finestructure.net>\r
  62         <87r57almd9.fsf@yoom.home.cworth.org>\r
  63 User-Agent: Notmuch/0.6 (http://notmuchmail.org) Emacs/23.3.1\r
  64         (x86_64-pc-linux-gnu)\r
  65 Date: Fri, 03 Jun 2011 14:26:48 -0700\r
  66 Message-ID: <87lixihahz.fsf@servo.factory.finestructure.net>\r
  67 MIME-Version: 1.0\r
  68 Content-Type: multipart/signed; boundary="=-=-=";\r
  69         micalg=pgp-sha256; protocol="application/pgp-signature"\r
  70 X-BeenThere: notmuch@notmuchmail.org\r
  71 X-Mailman-Version: 2.1.13\r
  72 Precedence: list\r
  73 List-Id: "Use and development of the notmuch mail system."\r
  74         <notmuch.notmuchmail.org>\r
  75 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  77 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  78 List-Post: <mailto:notmuch@notmuchmail.org>\r
  79 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  80 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  81         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  82 X-List-Received-Date: Fri, 03 Jun 2011 21:26:59 -0000\r
  83 \r
  84 --=-=-=\r
  85 Content-Transfer-Encoding: quoted-printable\r
  86 \r
  87 On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth <cworth@cworth.org> wrote:\r
  88 > On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins <jrollins@fines=\r
  89 tructure.net> wrote:\r
  90 > > The declaration of the GMimeStream pointer to stdout in\r
  91 > > format_part_content_text was somehow preventing subsequent printf\r
  92 > > calls from outputting to stdout if the output was redirected to a\r
  93 > > file.  Scoping the declaration to the actual use of the stream pointer\r
  94 > > works around this problem.\r
  95 >=20\r
  96 > This commit message sounds like we don't actually understand the problem\r
  97 > being fixed here.\r
  98 \r
  99 Well actually it's only meant to sound like the committer doesn't\r
 100 understand the problem!\r
 101 \r
 102 > I'd like to investigate this more. Perhaps with a test case?\r
 103 \r
 104 The current tests are how I found the problem!  Without this patch at\r
 105 least the multipart tests will fail.  I don't see how another test will\r
 106 add anything.\r
 107 \r
 108 Carl, if you (or anyone else) understands what the issue is, then please\r
 109 go ahead and modify the commit message.  I don't understand things\r
 110 enough myself to do any better.  Clearly there is some strange\r
 111 interaction with things that try to use stdout after\r
 112 g_mime_stream_file_new() has already grabbed it.\r
 113 \r
 114 I really wouldn't block on this, though, since the patch does fix an\r
 115 actual bug.\r
 116 \r
 117 jamie.\r
 118 \r
 119 --=-=-=\r
 120 Content-Type: application/pgp-signature\r
 121 \r
 122 -----BEGIN PGP SIGNATURE-----\r
 123 Version: GnuPG v1.4.11 (GNU/Linux)\r
 124 \r
 125 iQIcBAEBCAAGBQJN6VGZAAoJEO00zqvie6q8fJEP/2LacoimwdTtHAplFv9/xcv5\r
 126 r+TBiPu9yCNxbzmknYFPnYE2Lj2XzHZ+eEUyA+NTFYEdAekO6k8WbHrDCHrtcU7c\r
 127 mgqhjGByS+9VAxnb92bBkkBRNOJhRSsJDngnjPmFTzLCDDh1sp1cW3yy3tNzx0ha\r
 128 5e9n4p7QicCRdRsyd4ZVRWeTITzCUmgZaN/XJPcm0cDK7i0+PFVz1HchRAHEevjk\r
 129 /Am5i5vAHE1g7i6pPMxCP92bpJ7Btu200TPzcc+SoO3sUXWL5HrW1tcrWSmhtqFk\r
 130 MLCbF/fhDe0JdjpSiZjAmIFcQ7FjauodmIztusAk4vNJm5GtIZWZU+wPEHmKu31d\r
 131 gaTUxwmVtFNtrDz4al/jCtyvts/uOfCoahDAU1qZ9TLzdBnfyIHxATBvBjssjVqU\r
 132 eu3p8e5BR6a3+o8urxKUmy2iDycPA+LYQyLObgUtNycCWKv/BkF5Hswv1rJnFVkQ\r
 133 WxVG0jtoHupkbC/zRUar4bbRWk6RGhYQed4AJFs909GsyJd1BfLjcNsKexnGfQen\r
 134 DCbwz23nkJ24hosNuIeXLr7WIEvPh/Hr8rT7dSGdYEogU28Qq6fuaoEg6B5CYMDq\r
 135 H6oeqDEV4GlNNDhHXrf5XZx2Qw/oGQjBHYnsLfkaG1gCyg5cWCDinpZb0XBENtwv\r
 136 pDAb7l2NxUKj+vyiJ7sM\r
 137 =re27\r
 138 -----END PGP SIGNATURE-----\r
 139 --=-=-=--\r