1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0DD9C421165
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 07:31:05 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ZpShvND9v46P for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Jun 2013 07:30:57 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 29202429E4C
\r
19 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 07:30:57 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1BBAB100030;
\r
22 Sun, 2 Jun 2013 17:30:56 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: david@tethera.net, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...)
\r
26 In-Reply-To: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
27 References: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
28 User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Sun, 02 Jun 2013 17:30:55 +0300
\r
34 Message-ID: <m2fvx0d1pc.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 Cc: David Bremner <bremner@debian.org>
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 02 Jun 2013 14:31:05 -0000
\r
52 On Sun, Jun 02 2013, david@tethera.net wrote:
\r
54 > From: David Bremner <bremner@debian.org>
\r
56 > I can't see any benefit to the funcall, and it looks like the result
\r
57 > of cut-and-paste from some code that actually used a variable for the
\r
61 Looks sensible to me.
\r
67 > Mark and I were discussing some style issues in the context of pick,
\r
68 > and it seems to me that some of the elisp style in the current code
\r
69 > could be improved. I don't claim to be an elisp style expert by any
\r
70 > stretch of the imagination. It would be great if some experts could
\r
71 > add a section to devel/STYLE about elisp.
\r
74 > emacs/notmuch-message.el | 2 +-
\r
75 > emacs/notmuch-show.el | 6 +++---
\r
76 > emacs/notmuch.el | 4 ++--
\r
77 > 3 files changed, 6 insertions(+), 6 deletions(-)
\r
79 > diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
\r
80 > index 4dc4883..914bdd1 100644
\r
81 > --- a/emacs/notmuch-message.el
\r
82 > +++ b/emacs/notmuch-message.el
\r
83 > @@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set:
\r
84 > ;; get the in-reply-to header and parse it for the message id.
\r
85 > (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
\r
86 > (when (and notmuch-message-replied-tags rep)
\r
87 > - (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
88 > + (notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
89 > (notmuch-tag-change-list notmuch-message-replied-tags)))))
\r
91 > (add-hook 'message-send-hook 'notmuch-message-mark-replied)
\r
92 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
93 > index 613e666..18b4671 100644
\r
94 > --- a/emacs/notmuch-show.el
\r
95 > +++ b/emacs/notmuch-show.el
\r
96 > @@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
97 > (let* ((current-tags (notmuch-show-get-tags))
\r
98 > (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
99 > (unless (equal current-tags new-tags)
\r
100 > - (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
101 > + (notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
102 > (notmuch-show-set-tags new-tags))))
\r
104 > (defun notmuch-show-tag (&optional tag-changes)
\r
105 > @@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
107 > See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
109 > - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
110 > + (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
111 > (let* ((current-tags (notmuch-show-get-tags))
\r
112 > (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
113 > (unless (equal current-tags new-tags)
\r
114 > @@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
116 > See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
118 > - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
119 > + (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
120 > (notmuch-show-mapc
\r
122 > (let* ((current-tags (notmuch-show-get-tags))
\r
123 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
124 > index 5a8c957..af107e2 100644
\r
125 > --- a/emacs/notmuch.el
\r
126 > +++ b/emacs/notmuch.el
\r
127 > @@ -562,7 +562,7 @@ will be signaled."
\r
128 > (defun notmuch-search-tag-region (beg end &optional tag-changes)
\r
129 > "Change tags for threads in the given region."
\r
130 > (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
\r
131 > - (setq tag-changes (funcall 'notmuch-tag search-string tag-changes))
\r
132 > + (setq tag-changes (notmuch-tag search-string tag-changes))
\r
133 > (notmuch-search-foreach-result beg end
\r
135 > (notmuch-search-set-tags
\r
136 > @@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
138 > (let* ((beg (if (region-active-p) (region-beginning) (point)))
\r
139 > (end (if (region-active-p) (region-end) (point))))
\r
140 > - (funcall 'notmuch-search-tag-region beg end tag-changes)))
\r
141 > + (notmuch-search-tag-region beg end tag-changes)))
\r
143 > (defun notmuch-search-add-tag ()
\r
144 > "Same as `notmuch-search-tag' but sets initial input to '+'."
\r
148 > _______________________________________________
\r
149 > notmuch mailing list
\r
150 > notmuch@notmuchmail.org
\r
151 > http://notmuchmail.org/mailman/listinfo/notmuch
\r