1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 1CE666DE0AF8
\r
6 for <notmuch@notmuchmail.org>; Sat, 13 Feb 2016 09:11:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.307 tagged_above=-999 required=5 tests=[AWL=0.244,
\r
12 RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id TVJ8ETaEBGqV for <notmuch@notmuchmail.org>;
\r
16 Sat, 13 Feb 2016 09:11:25 -0800 (PST)
\r
17 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 60ED26DE0A9A
\r
19 for <notmuch@notmuchmail.org>; Sat, 13 Feb 2016 09:11:25 -0800 (PST)
\r
20 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
\r
21 (envelope-from <bremner@tethera.net>)
\r
22 id 1aUdiV-0004K3-5I; Sat, 13 Feb 2016 12:10:43 -0500
\r
23 Received: (nullmailer pid 9990 invoked by uid 1000);
\r
24 Sat, 13 Feb 2016 17:11:23 -0000
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: notmuch@notmuchmail.org
\r
27 Subject: [PATCH 1/2] STYLE: document some rules about variable declarations
\r
28 Date: Sat, 13 Feb 2016 13:11:18 -0400
\r
29 Message-Id: <1455383479-9946-1-git-send-email-david@tethera.net>
\r
30 X-Mailer: git-send-email 2.6.4
\r
31 X-BeenThere: notmuch@notmuchmail.org
\r
32 X-Mailman-Version: 2.1.20
\r
34 List-Id: "Use and development of the notmuch mail system."
\r
35 <notmuch.notmuchmail.org>
\r
36 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
37 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
38 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
39 List-Post: <mailto:notmuch@notmuchmail.org>
\r
40 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
41 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
43 X-List-Received-Date: Sat, 13 Feb 2016 17:11:27 -0000
\r
45 No-one seemed opposed to C99 style loop variable declarations. The
\r
46 requirement to declare variables at the top of blocks is maybe a little
\r
47 more contested, but I believe it reflects the status quo.
\r
49 devel/STYLE | 7 ++++---
\r
50 1 file changed, 4 insertions(+), 3 deletions(-)
\r
52 diff --git a/devel/STYLE b/devel/STYLE
\r
53 index 24bd548..b22d8d3 100644
\r
56 @@ -25,9 +25,7 @@ The following nonsense code demonstrates many aspects of the style:
\r
58 function (param_type param, param_type param)
\r
62 - for (i = 0; i < 10; i++) {
\r
63 + for (int i = 0; i < 10; i++) {
\r
67 @@ -64,6 +62,9 @@ function (param_type param, param_type param)
\r
68 * Code lines should be less than 80 columns and comments should be
\r
69 wrapped at 70 columns.
\r
71 +* Variable declarations should be at the top of a block; C99 style
\r
72 + control variable declarations in for loops are also OK.
\r