3a/de12a8880e23548038b2fc1716a74b53e94f6a

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 376CF431FD0\r
   6         for <notmuch@notmuchmail.org>; Tue, 12 Jul 2011 22:03:29 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id Vrv6w1mBZ-Wg for <notmuch@notmuchmail.org>;\r
  16         Tue, 12 Jul 2011 22:03:28 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id BBCC2431FB6\r
  20         for <notmuch@notmuchmail.org>; Tue, 12 Jul 2011 22:03:28 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7bcaae000000a1b-b9-4e1d26f79f8e\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id F0.05.02587.7F62D1E4; Wed, 13 Jul 2011 01:02:47 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id p6D53RH5019787; \r
  27         Wed, 13 Jul 2011 01:03:28 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id p6D53Qao003253\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Wed, 13 Jul 2011 01:03:27 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.72)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1QgrbQ-0004tA-7E; Wed, 13 Jul 2011 01:03:16 -0400\r
  37 Date: Wed, 13 Jul 2011 01:03:16 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Istvan Marko <notmuch@kismala.com>\r
  40 Subject: Re: Slowness (search opens every email file?)\r
  41 Message-ID: <20110713050316.GH25558@mit.edu>\r
  42 References: <20110711190721.GA5386@compy.jasonwoof.org>\r
  43         <CAH-f9WtBHJ8bL6eWoSNrTs=jkrOYYCuWEVVPDUt_iCw0dKcZbw@mail.gmail.com>\r
  44         <20110712202459.GB15019@compy.jasonwoof.org>\r
  45         <CAH-f9WujE8s3DK1PyDGf3kdWLx2qvPx=dp7WZ-z_v8prqauvug@mail.gmail.com>\r
  46         <m3pqlfhrkk.fsf@zsu.kismala.com> <20110713022247.GG25558@mit.edu>\r
  47         <m3liw2j2u3.fsf@zsu.kismala.com>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 Content-Disposition: inline\r
  51 In-Reply-To: <m3liw2j2u3.fsf@zsu.kismala.com>\r
  52 User-Agent: Mutt/1.5.20 (2009-06-14)\r
  53 X-Brightmail-Tracker:\r
  54  H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT1/2uJutncOe1jcXL3doW12/OZHZg\r
  55         8vi86Cmjx7NVt5gDmKK4bFJSczLLUov07RK4Mvp6v7MW9HFUPOjbydTAuJqti5GTQ0LAROL3\r
  56         5PVMELaYxIV764HiXBxCAvsYJR73f2OBcDYwSrT1vGSFcE4ySWw5tJgZwlnCKLGhYz1jFyMH\r
  57         B4uAqsSDtyYgo9gENCS27V8OFhYRUJN48iwfJMwsoCWxdeMHRhBbWMBM4uq+V2A2r4COxKN5\r
  58         V5lBbCGBu0wSpybnQMQFJU7OfMIC03vj30smkJHMAtISy/9xgIQ5BXQlnr9dC1YiKqAicW1/\r
  59         O9sERqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6FXm5miV5qSukmRnBI\r
  60         u6juYJxwSOkQowAHoxIPr0S8jJ8Qa2JZcWXuIUZJDiYlUd6FKrJ+QnxJ+SmVGYnFGfFFpTmp\r
  61         xYcYJTiYlUR41/8GKudNSaysSi3Kh0lJc7AoifOGeP/3FRJITyxJzU5NLUgtgsnKcHAoSfB2\r
  62         AGNXSLAoNT21Ii0zpwQhzcTBCTKcB2j4P1WgGt7igsTc4sx0iPwpRkUpcd4pIM0CIImM0jy4\r
  63         XljKecUoDvSKMG8pSBUPMF3Bdb8CGswENPi1tCTI4JJEhJRUA6Ps5AUL160LUTq6z/r/pHl6\r
  64         Ahz3Hqx6ofJONS1eL2SejMitaxMuJbP1+ljuSt2V/ORat8/XCdkpbTtzflq63z21aWnV8bJb\r
  65         0To7ZBawfn2ak3TX0mZC1sF3ZeW7Q5tC3jPlir9Oc2OTO/P9TcEVm6DmmyfOscfpa93MiPvi\r
  66         wyqbcP3LhR8yffVKLMUZiYZazEXFiQBzQhCiFAMAAA==\r
  67 Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
  68 X-BeenThere: notmuch@notmuchmail.org\r
  69 X-Mailman-Version: 2.1.13\r
  70 Precedence: list\r
  71 List-Id: "Use and development of the notmuch mail system."\r
  72         <notmuch.notmuchmail.org>\r
  73 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  75 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  76 List-Post: <mailto:notmuch@notmuchmail.org>\r
  77 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  78 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  79         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  80 X-List-Received-Date: Wed, 13 Jul 2011 05:03:29 -0000\r
  81 \r
  82 Quoth Istvan Marko on Jul 12 at  8:07 pm:\r
  83 > Austin Clements <amdragon@MIT.EDU> writes:\r
  84 > \r
  85 > > I'd say this patch looks good other than coding style\r
  86 > > - Tab indentation\r
  87 > > - /* */ comments, starting with a capital letter\r
  88 > > - Space between function name and open paren\r
  89 > > - Space after comma in argument lists\r
  90 > > - Spaces around assignment operator\r
  91 > \r
  92 > Thanks, fixed the ones I see:\r
  93 \r
  94 +    /* Fetch header from the appropriate xapian value field if\r
  95 +     * available */\r
  96 +    if (strcmp(header, "from") == 0)\r
  97 +       value = message->doc.get_value(NOTMUCH_VALUE_FROM);\r
  98 +    else if (strcmp(header, "subject") == 0)\r
  99 +       value = message->doc.get_value (NOTMUCH_VALUE_SUBJECT);\r
 100 +    else if (strcmp(header, "message-id") == 0)\r
 101 +       value = message->doc.get_value (NOTMUCH_VALUE_MESSAGE_ID);\r
 102 \r
 103 The strcmp's should have a space before the paren, as should the first\r
 104 get_value.  (Yeah, it's weird.  Blame glib.)\r
 105 \r
 106 Also, it occurred to me that these should be strcasecmp's, since\r
 107 headers are case-insensitive.\r