1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E36B3431FAE
\r
6 for <notmuch@notmuchmail.org>; Tue, 22 May 2012 13:48:02 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.274 tagged_above=-999 required=5
\r
12 tests=[RDNS_NONE=1.274] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id LxOgpesY2OUT for <notmuch@notmuchmail.org>;
\r
16 Tue, 22 May 2012 13:48:01 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (unknown [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 2D8E9431FBC
\r
19 for <notmuch@notmuchmail.org>; Tue, 22 May 2012 13:48:01 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 462A9100641; Tue, 22 May 2012 23:48:00 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases
\r
25 In-Reply-To: <1337314423-3702-1-git-send-email-amdragon@mit.edu>
\r
26 References: <1337314423-3702-1-git-send-email-amdragon@mit.edu>
\r
27 User-Agent: Notmuch/0.13~rc1+40~g96c989b (http://notmuchmail.org) Emacs/23.1.1
\r
28 (x86_64-redhat-linux-gnu)
\r
29 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
30 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
31 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
32 Date: Tue, 22 May 2012 23:48:00 +0300
\r
33 Message-ID: <m2aa10uem7.fsf@guru.guru-group.fi>
\r
35 Content-Type: text/plain; charset=us-ascii
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Tue, 22 May 2012 20:48:03 -0000
\r
50 Austin Clements <amdragon@MIT.EDU> writes:
\r
52 > This fixes notmuch_database_get_directory and
\r
53 > notmuch_database_find_message_by_filename so that they don't attempt
\r
54 > to create missing directory documents. This makes them work on
\r
55 > read-only databases (and prevents n_d_f_m_b_f from crashing
\r
56 > unceremoniously on read-only databases).
\r
58 > Unfortunately, there are several functions involved in directory
\r
59 > document lookup, so the first three patches simply add a creation flag
\r
60 > at each necessary layer. The remaining patches then fix up the two
\r
61 > API functions and their uses.
\r
63 > If we do a 0.13.1 bug fix release, these patches could go in to
\r
64 > complement the API changes made in 0.13 to support these fixes. David
\r
65 > can make that call.
\r
67 > There are several patches, but they're all short and incremental.
\r
69 This patch series looks good to me...
\r
76 > bindings/python/notmuch/database.py | 11 -----------
\r
77 > lib/database.cc | 40 +++++++++++++++++++++++++---------------
\r
78 > lib/directory.cc | 41 +++++++++++++++++++++++++++++++++++------
\r
79 > lib/message.cc | 11 +++++------
\r
80 > lib/notmuch-private.h | 13 +++++++++++++
\r
81 > lib/notmuch.h | 10 ++--------
\r
82 > notmuch-new.c | 36 +++++++-----------------------------
\r
83 > test/python | 8 ++++++++
\r
84 > 8 files changed, 95 insertions(+), 75 deletions(-)
\r
86 > _______________________________________________
\r
87 > notmuch mailing list
\r
88 > notmuch@notmuchmail.org
\r
89 > http://notmuchmail.org/mailman/listinfo/notmuch
\r