1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B3954431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:16 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id frfdmXqvWdYZ for <notmuch@notmuchmail.org>;
\r
16 Sat, 12 Apr 2014 03:50:09 -0700 (PDT)
\r
17 Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com
\r
18 [74.125.83.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 4AB77431FAF for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:09 -0700
\r
22 Received: by mail-ee0-f43.google.com with SMTP id e53so4894895eek.2
\r
23 for <notmuch@notmuchmail.org>; Sat, 12 Apr 2014 03:50:05 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
27 :user-agent:date:message-id:mime-version:content-type;
\r
28 bh=YZ96Gf4DLF+X8lVbESyyBoU2U7lzYxdGnAwgmxhgYH8=;
\r
29 b=UzbFNStOrgbVFyD9rHV8bK1PDXrntW0M7OxpaU8C2scOAxlw/sCSEA/kKVs+lUE7NZ
\r
30 00MfSPHFCwmqnIbQRZgXDhiVZlsWd88tmYkrP8nkgN2jhBjaGeNViX28g+k95ax2u8cX
\r
31 eyFgHfbWl8914y+RVq7k//xihoXrOlPHIRkXQIgxYkQx9eacZt+z+vjyaH+ssOk4ZVrE
\r
32 MR1ODYj8KtgmTp23UZSPX2zP6oG5eFKCrXPawWtXzVhUpxt5jlDEe3BbfwXKNOf94LlI
\r
33 LjBBQld15L2RxgsZgu4U2V1UiVeg7SbO1yp8iZdfTv0I4X0FOluEhsLyRORenYS933Bv
\r
36 ALoCoQnhfN0jem9rxqZaH12pWGzEfFX/sqR7kx1gP9/F2x+WIesvujhX1Deq+GXE2dhNkMz55WET
\r
37 X-Received: by 10.14.251.204 with SMTP id b52mr36023968ees.36.1397299805056;
\r
38 Sat, 12 Apr 2014 03:50:05 -0700 (PDT)
\r
39 Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
\r
40 [88.195.111.91]) by mx.google.com with ESMTPSA id
\r
41 q49sm24447573eem.34.2014.04.12.03.50.03 for <multiple recipients>
\r
42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
43 Sat, 12 Apr 2014 03:50:04 -0700 (PDT)
\r
44 From: Jani Nikula <jani@nikula.org>
\r
45 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
46 Subject: Re: [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted
\r
48 In-Reply-To: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>
\r
49 References: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>
\r
50 User-Agent: Notmuch/0.17+187~gf1bfa36 (http://notmuchmail.org) Emacs/24.3.1
\r
51 (x86_64-pc-linux-gnu)
\r
52 Date: Sat, 12 Apr 2014 13:50:02 +0300
\r
53 Message-ID: <878ura7rfp.fsf@nikula.org>
\r
55 Content-Type: text/plain
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Sat, 12 Apr 2014 10:50:16 -0000
\r
70 On Sat, 12 Apr 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
71 > My recent changes to the saved search format broke the alphabetically
\r
72 > sorted saved sort option. This makes it work again.
\r
74 > Also, since the saved-search list is no longer an alist change the
\r
75 > names in the sort function to avoid confusion.
\r
77 > Thanks to Jani for pointing out the bug.
\r
79 Looks good, works for me, thanks for the fix.
\r
89 > emacs/notmuch-hello.el | 9 ++++++---
\r
90 > 1 file changed, 6 insertions(+), 3 deletions(-)
\r
92 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
93 > index 4900a24..fca2bcc 100644
\r
94 > --- a/emacs/notmuch-hello.el
\r
95 > +++ b/emacs/notmuch-hello.el
\r
96 > @@ -39,9 +39,12 @@ (defcustom notmuch-show-empty-saved-searches nil
\r
98 > :group 'notmuch-hello)
\r
100 > -(defun notmuch-sort-saved-searches (alist)
\r
101 > - "Generate an alphabetically sorted saved searches alist."
\r
102 > - (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))
\r
103 > +(defun notmuch-sort-saved-searches (saved-searches)
\r
104 > + "Generate an alphabetically sorted saved searches list."
\r
105 > + (sort (copy-sequence saved-searches)
\r
107 > + (string< (notmuch-saved-search-get a :name)
\r
108 > + (notmuch-saved-search-get b :name)))))
\r
110 > (defcustom notmuch-saved-search-sort-function nil
\r
111 > "Function used to sort the saved searches for the notmuch-hello view.
\r
115 > _______________________________________________
\r
116 > notmuch mailing list
\r
117 > notmuch@notmuchmail.org
\r
118 > http://notmuchmail.org/mailman/listinfo/notmuch
\r