1 Return-Path: <matt@bubblegen.co.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 2FD876DE014D
\r
6 for <notmuch@notmuchmail.org>; Fri, 22 Jul 2016 09:47:33 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.72 tagged_above=-999 required=5 tests=[AWL=0.000,
\r
12 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,
\r
13 RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled
\r
14 Received: from arlo.cworth.org ([127.0.0.1])
\r
15 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id R3ms9OYYbA-e for <notmuch@notmuchmail.org>;
\r
17 Fri, 22 Jul 2016 09:47:25 -0700 (PDT)
\r
18 Received: from avasout07.plus.net (avasout07.plus.net [84.93.230.235])
\r
19 by arlo.cworth.org (Postfix) with ESMTPS id 365C16DE00C8
\r
20 for <notmuch@notmuchmail.org>; Fri, 22 Jul 2016 09:47:25 -0700 (PDT)
\r
21 Received: from webmail04.plus.net ([84.93.228.66]) by avasout07 with smtp
\r
22 id MsnN1t0071SbfYc01snNBn; Fri, 22 Jul 2016 17:47:23 +0100
\r
24 X-CNFS-Analysis: v=2.2 cv=UYYTc+aN c=1 sm=1 tr=0
\r
25 a=C5+YawzV8SR07mwocaP9vA==:117 a=6WEHsjNRvCJYAr8w9WnCiA==:17
\r
26 a=cAmyUtKerLwA:10 a=H4IEW4q-AAAA:8 a=mEHJS5tcBp7mKnBcrAgA:9
\r
27 a=kz_rP2hIBAIkRpJ1_vYA:9 a=Nf2LC8gUDJIA:10 a=CdiWusdWvyIA:10
\r
28 a=AS9mAr_Iad8o7WnExNUa:22
\r
29 Received: from localhost ([127.0.0.1] helo=webmail.plus.net)
\r
30 by webmail04.plus.net with esmtp (Exim 4.76)
\r
31 (envelope-from <matt@bubblegen.co.uk>)
\r
32 id 1bQdbe-00057U-Hn; Fri, 22 Jul 2016 17:47:22 +0100
\r
33 Received: from 80.82.130.242 (SquirrelMail authenticated user bubblegen+matt)
\r
34 by webmail.plus.net with HTTP; Fri, 22 Jul 2016 17:47:22 +0100
\r
35 Message-ID: <3d06c4bede0643230bea93cb5d58ca6d.squirrel@webmail.plus.net>
\r
36 In-Reply-To: <87lh4wj4kq.fsf@zancas.localnet>
\r
37 References: <f50e07855e9bbbdd780ef925d8e2d879.squirrel@webmail.plus.net>
\r
38 <m2a8miwc6x.fsf@dme.org>
\r
39 <c4ff9f2c141441be10b1cb4b1e0300a7.squirrel@webmail.plus.net>
\r
40 <56DD48B3.90604@bubblegen.co.uk> <87mvqatr6y.fsf@zancas.localnet>
\r
41 <87h9gigfyz.fsf@bubblegen.co.uk> <87pov58b9y.fsf@zancas.localnet>
\r
42 <m260wxkvf3.fsf@guru.guru-group.fi> <87wpp76ctq.fsf@zancas.localnet>
\r
43 <m2shzvrccn.fsf@dme.org> <87h9fm315q.fsf@bubblegen.co.uk>
\r
44 <87oa9timv7.fsf@zancas.localnet>
\r
45 <575b60a1d39a1ecc7d06e5c0d625be61.squirrel@webmail.plus.net>
\r
46 <87bn5tjw5e.fsf@tesseract.cs.unb.ca>
\r
47 <5ed42cd5aafdc045b5d9e1b918d10748.squirrel@webmail.plus.net>
\r
48 <87mvpdgp38.fsf@bubblegen.co.uk> <87lh4wj4kq.fsf@zancas.localnet>
\r
49 Date: Fri, 22 Jul 2016 17:47:22 +0100
\r
50 Subject: Re: (emacs) Parsing problems replying to encrypted html
\r
51 From: "Matthew Lear" <matt@bubblegen.co.uk>
\r
52 To: "David Bremner" <david@tethera.net>
\r
53 Cc: "Matthew Lear" <matt@bubblegen.co.uk>, notmuch@notmuchmail.org,
\r
54 "David Edmondson" <dme@dme.org>, "Mark Walters" <markwalters1009@gmail.com>
\r
55 Reply-To: matt@bubblegen.co.uk
\r
56 User-Agent: SquirrelMail
\r
58 Content-Type: multipart/mixed;boundary="----=_20160722174722_30667"
\r
59 X-Priority: 3 (Normal)
\r
61 X-BeenThere: notmuch@notmuchmail.org
\r
62 X-Mailman-Version: 2.1.20
\r
64 List-Id: "Use and development of the notmuch mail system."
\r
65 <notmuch.notmuchmail.org>
\r
66 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
68 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
69 List-Post: <mailto:notmuch@notmuchmail.org>
\r
70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
71 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
73 X-List-Received-Date: Fri, 22 Jul 2016 16:47:33 -0000
\r
75 ------=_20160722174722_30667
\r
76 Content-Type: text/plain; charset="iso-8859-1"
\r
77 Content-Transfer-Encoding: 8bit
\r
81 > OK, with that setting I can duplicate the problem replying to encrypted
\r
84 > It's also true that notmuch-reply doesn't include the content in the
\r
85 > html version of the multipart/alternative. Unlike notmuch show, it
\r
86 > doesn't have the ability to send parts later, so I guess that's a
\r
89 > The following patch seems to fix it for me. What I haven't worked out is
\r
90 > if it will break other things. Perhaps David E or Mark (in copy) can
\r
91 > comment on whether this is a sensible change, given that we now give the
\r
92 > user control of showing the part on the emacs side.
\r
94 > diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
95 > index 3c6d685..cd88d79 100644
\r
96 > --- a/notmuch-reply.c
\r
97 > +++ b/notmuch-reply.c
\r
98 > @@ -690,7 +690,7 @@ notmuch_reply_format_sprinter(void *ctx,
\r
100 > /* Start the original */
\r
101 > sp->map_key (sp, "original");
\r
102 > - format_part_sprinter (ctx, sp, node, TRUE, TRUE, FALSE);
\r
103 > + format_part_sprinter (ctx, sp, node, TRUE, TRUE, TRUE);
\r
108 I could have sworn that I replied to this thread months ago but can't find
\r
109 a record it in the archives... I think I also missed David E's reply to
\r
110 yours mentioning the patch from id:1459708823-1852-1-git-send-email-dme at
\r
111 dme.org, so I'm following up...
\r
113 With David E's patch, the decryption problem I reported is resolved.
\r
114 However, I notice that this change hasn't yet been committed / pushed. Is
\r
115 there a particular reason for this?
\r
117 I'm currently maintaining a version of this patch compatible with the
\r
118 current master which makes this change to notmuch-mua.el
\r
119 notmuch-mua-reply() by adding (notmuch-show-process-crypto process-crypto)
\r
120 before doing the show. I've attached that patch here.
\r
122 I just wondered if we were going to see this pushed to master any time soon?
\r
127 ------=_20160722174722_30667
\r
128 Content-Type: text/x-patch; name="fix-encrypted-html.patch"
\r
129 Content-Transfer-Encoding: 8bit
\r
130 Content-Disposition: attachment; filename="fix-encrypted-html.patch"
\r
132 diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
133 index 0445975..0dcdb06 100644
\r
134 --- a/emacs/notmuch-mua.el
\r
135 +++ b/emacs/notmuch-mua.el
\r
136 @@ -250,7 +250,11 @@ mutiple parts get a header."
\r
137 ;; Don't omit long parts.
\r
138 (notmuch-show-max-text-part-size 0)
\r
139 ;; Insert headers for parts as appropriate for replying.
\r
140 - (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
\r
141 + (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
\r
142 + ;; Ensure that any encrypted parts are
\r
143 + ;; decrypted during the generation of the reply
\r
145 + (notmuch-show-process-crypto process-crypto)
\r
146 ;; Don't indent multipart sub-parts.
\r
147 (notmuch-show-indent-multipart nil))
\r
148 (notmuch-show-insert-body original (plist-get original :body) 0)
\r
149 ------=_20160722174722_30667--
\r