Re: Flat search and threaded views
[notmuch-archives.git] / 35 / 2e93c9e09f7aaef410b58af07bdcc6ad4c0d73
1 Return-Path: <mpn@google.com>\r
2 X-Original-To: notmuch@notmuchmail.org\r
3 Delivered-To: notmuch@notmuchmail.org\r
4 Received: from localhost (localhost [127.0.0.1])\r
5         by olra.theworths.org (Postfix) with ESMTP id 0882A431FB6\r
6         for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:16 -0700 (PDT)\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
8 X-Spam-Flag: NO\r
9 X-Spam-Score: -0.8\r
10 X-Spam-Level: \r
11 X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5\r
12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
14 Received: from olra.theworths.org ([127.0.0.1])\r
15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
16         with ESMTP id rXkzqbjgyWLL for <notmuch@notmuchmail.org>;\r
17         Mon, 27 Aug 2012 16:11:15 -0700 (PDT)\r
18 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
19  [74.125.83.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
20  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
21  2E53A431FAE    for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:15 -0700\r
22  (PDT)\r
23 Received: by eekb47 with SMTP id b47so1360458eek.26\r
24         for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
26  s=20120113;    h=from:to:subject:in-reply-to:organization:references:user-agent\r
27         :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version        :content-type;\r
28  bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=;\r
29         b=gPYdEjC1rrbFBabZndKeYYk5xuduXoRDxKKDiCnLXbvEc7jswBDJuLECPNKf59y3Kp\r
30         aIceErCFh9BaFJf3w+aGTiPWP/WSfqWwOic4IxBJQAIOiWVId4Xb40PMWG94NRXHPmgQ\r
31         mdUnTMO3uklBF/Fs/hOdPfrXyI86xQotjJ+/5U9HbiiENMgbSWb4/e17G9nV4YnzTy/B\r
32         KcY2F+75KQI2CgdRQx/589OI5Eyy2vhOdtXVYmIYMsgyiIJo25thwZDS4Nog4NKjjhXw\r
33         ehhXnQ4c3ZAdn8ySgzjtswP8dXIRnfpTdRm82/tdgu5ieAC2pFlAw7u7biyG+Iu0I3C/    eqUQ==\r
34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
35         d=google.com; s=20120113;\r
36         h=from:to:subject:in-reply-to:organization:references:user-agent\r
37         :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
38         :content-type:x-gm-message-state;\r
39         bh=Ik/J2ID7GdU9IRmafYP+07DA21IUugVYKa+pPyfZ5cY=;\r
40         b=EctxjKnRsEqhzQYrzw/WuQNu6SUBa/t6eRddnkwfxd9OIpbpeOyuAKt9LJY8ZhALws\r
41         sS5+mz4ewEHG6rJ5Jgrfg1+SoiGZQFvM4sUqxxDfZi3Vte50GOXgZr1H3Lyd+cxdAiVi\r
42         B9zp03xYg2SxIpYiu1VqtkhLs928k68/CnMjrmFhtRSI9+w4SvJXl9n+y0F0Rrj4d1Wj\r
43         45/mvvNrfCODqqWcCtKNFb2rDrLVAQtdgoUQwBmWcqDkm0+03/MCzbZ00gKgvkWlUNWa\r
44         edo5OuH0o5MFzj5tWwgTSSwNIYuDT8OuIo2k7WwD/Ccw2AXw5gGEfI1AbkkfjuWV1rMO\r
45         OAuw==\r
46 Received: by 10.14.203.69 with SMTP id e45mr3363469eeo.23.1346109073918;\r
47         Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
48 Received: by 10.14.203.69 with SMTP id e45mr3363457eeo.23.1346109073753;\r
49         Mon, 27 Aug 2012 16:11:13 -0700 (PDT)\r
50 Received: from mpn-glaptop ([2620:0:105f:5:f2de:f1ff:fe35:1a72])\r
51         by mx.google.com with ESMTPS id v3sm56095064eep.10.2012.08.27.16.11.10\r
52         (version=TLSv1/SSLv3 cipher=OTHER);\r
53         Mon, 27 Aug 2012 16:11:12 -0700 (PDT)\r
54 From: Michal Nazarewicz <mpn@google.com>\r
55 To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
56  notmuch@notmuchmail.org\r
57 Subject: Re: [PATCH] emacs: notmuch-search: fix faces\r
58 In-Reply-To: <87ipc4jcfv.fsf@servo.finestructure.net>\r
59 Organization: Google Inc\r
60 References:\r
61  <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>\r
62         <87ipc4jcfv.fsf@servo.finestructure.net>\r
63 User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1\r
64         (x86_64-unknown-linux-gnu)\r
65 X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;        KFrfMCylc}gc??'U2j,!8%xdD\r
66 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
67 X-PGP: 50751FF4\r
68 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
69 Date: Tue, 28 Aug 2012 01:11:05 +0200\r
70 Message-ID: <xa1t3938ue0m.fsf@mina86.com>\r
71 MIME-Version: 1.0\r
72 Content-Type: multipart/mixed; boundary="=-=-="\r
73 X-Gm-Message-State: ALoCoQmzDF4KkvfdPFFFhX5REkahG/bX9c7mC8ZD+WnG3PTvpfeKUbt37xVGHbKsEPhoPGnimwz09v/1rpEHqRukkybXYQDdw+LFPEfJjks6tPyp7//xJQvu/APB8X6w2Ac/FubtSSMDMC1jC0Jr9HWK2L0vxBdOjWVaDTvCpaQm4Aoi0PbPKlMLiUtwxMHzHUml7AtCb09ukyTPXfSZb4I8eMQ7JqKDRA==\r
74 X-BeenThere: notmuch@notmuchmail.org\r
75 X-Mailman-Version: 2.1.13\r
76 Precedence: list\r
77 List-Id: "Use and development of the notmuch mail system."\r
78         <notmuch.notmuchmail.org>\r
79 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
80         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
81 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
82 List-Post: <mailto:notmuch@notmuchmail.org>\r
83 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
84 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
85         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
86 X-List-Received-Date: Mon, 27 Aug 2012 23:11:16 -0000\r
87 \r
88 --=-=-=\r
89 Content-Type: text/plain; charset=utf-8\r
90 Content-Transfer-Encoding: quoted-printable\r
91 \r
92 > On Thu, Aug 23 2012, Michal Nazarewicz <mpn@google.com> wrote:\r
93 >> For some reason the faces do not get applied when 'face property is\r
94 >> used, but they work correctly with 'font-lock-face property.  This\r
95 >> commit changes notmuch-search to use the latter.\r
96 \r
97 Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
98 > Hi, Michal.  Can you say a bit more about what's motivating this?  This\r
99 > feature seems to work fine for me, so I would like to understand what's\r
100 > not working for you.  I'm certainly no expert on emacs font handling,\r
101 > though, so maybe this is the proper thing to do.  Thanks.\r
102 \r
103 I'm not an expert either, but with this patch applied I see colours,\r
104 without this patch, I don't see colours, ie. everything is rendered\r
105 using the default face.\r
106 \r
107 I'm also not entirely sure if that's the correct way of doing things\r
108 since 'face seems to be working in other modes (most notably\r
109 notmuch-show).  By posting, I'm also hoping that someone more\r
110 experienced will maybe take a look to see what's going on here... ;)\r
111 \r
112 For some more info, in notmuch-show mode, I get-text-property of nil for\r
113 both 'face and 'font-lock-face, but in message-mode or in *scratch*\r
114 buffer I'm getting nil for 'font-lock-face but non-nil for 'face.  With\r
115 the patch, I'm getting the same non-nil for both 'face and\r
116 'font-lock-face; without the patch, I'm getting nil for both.\r
117 \r
118 --=20\r
119 Best regards,                                         _     _\r
120 .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
121 ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
122  (o o)\r
123 ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
124 --=-=-=\r
125 Content-Type: multipart/signed; boundary="==-=-=";\r
126         micalg=pgp-sha1; protocol="application/pgp-signature"\r
127 \r
128 --==-=-=\r
129 Content-Type: text/plain\r
130 \r
131 \r
132 --==-=-=\r
133 Content-Type: application/pgp-signature\r
134 \r
135 -----BEGIN PGP SIGNATURE-----\r
136 Version: GnuPG v1.4.10 (GNU/Linux)\r
137 \r
138 iQIcBAEBAgAGBQJQO/6JAAoJECBgQBJQdR/0akcQAIHv7HM1dpg8CdL91ZgHus10\r
139 k+QwrXnTyr3GoRsJrD3sPZEnXc1FxXFJbMNq+b+nBfsU6Ihjv8WpuqMP/K3amo5f\r
140 x3lEjsvnsUB8Is8/lvp3OuGW9l8+AhWphX6dB2n3uqUTy0w6xzurwB5JHEUG0Z+C\r
141 IHs45QfvVhkw7BEpV3o8FCDcP0letSbFg2ff2AnASFoHh8nykeVo1e/hjWp0qJao\r
142 t1nYwxjw2g000O81aNN6xxbbksfxlNWvquypnCmUIHbhBROLgaJKCKs6/MskEA30\r
143 BNuXsDB81TwVBcoyO83ttl1zU9CdCrq6cUkEYvQy8aZxn5Isn0jeg5vGnzh7mm3J\r
144 g5jIb3eohBX2MngafLqVGrCrzGolZjXqF+GekllDNuVUcfqXychhpiBRNE+XZ+2T\r
145 i8Hj/PTRCvTKRg/vIqCQma4cSo2qtJ0hMW0or7McNZ8XWne1tFPKqJ3It4qBFrqf\r
146 SKRZPD6V41X3U44sRQ+SQ6hTfyNHkOIVwGNVQ6ZPs84/x9J2JuUJ0FxQq26s9Ne2\r
147 7QLQaEdswBzvsdKS1+2AMvIXirq+mIFTIcrpjzaUWEgKcWTSO4o5t3l8s8VJ+wz2\r
148 iav9EAxIlxdXma6rnd2n3/ER+3RzUL361FI31v1/a2bEU1z1xRi/ihOzYHRpojz5\r
149 0yRaBPwWAwPQMXvyMjBz\r
150 =C4xR\r
151 -----END PGP SIGNATURE-----\r
152 --==-=-=--\r
153 \r
154 --=-=-=--\r