Reply all - issue

[notmuch-archives.git] / 34 / 62967955fc0c000c2b1caf0da77709a529a2b9

Return-Path: <tomi.ollila@iki.fi>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id AB409431FC0\r
        for <notmuch@notmuchmail.org>; Tue,  7 Aug 2012 09:08:57 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: 0\r
X-Spam-Level: \r
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
        autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id qRljlw5DCpLR for <notmuch@notmuchmail.org>;\r
        Tue,  7 Aug 2012 09:08:57 -0700 (PDT)\r
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
        by olra.theworths.org (Postfix) with ESMTP id EF63F431FAF\r
        for <notmuch@notmuchmail.org>; Tue,  7 Aug 2012 09:08:56 -0700 (PDT)\r
Received: by guru.guru-group.fi (Postfix, from userid 501)\r
        id A474E1002A4; Tue,  7 Aug 2012 19:09:05 +0300 (EEST)\r
From: Tomi Ollila <tomi.ollila@iki.fi>\r
To: Mark Walters <markwalters1009@gmail.com>,\r
        Austin Clements <amdragon@MIT.EDU>\r
Subject: Re: [PATCH] emacs: notmuch search bugfix\r
In-Reply-To: <87pq72bthc.fsf@qmul.ac.uk>\r
References: <87boinpqfg.fsf@qmul.ac.uk> <20120806234732.GM22601@mit.edu>\r
        <87pq72bthc.fsf@qmul.ac.uk>\r
User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1\r
        (x86_64-redhat-linux-gnu)\r
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
        $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
        !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
Date: Tue, 07 Aug 2012 19:09:05 +0300\r
Message-ID: <m2boimofa6.fsf@guru.guru-group.fi>\r
MIME-Version: 1.0\r
Content-Type: text/plain; charset=us-ascii\r
Cc: notmuch@notmuchmail.org\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Tue, 07 Aug 2012 16:08:57 -0000\r
\r
On Tue, Aug 07 2012, Mark Walters wrote:\r
\r
> The recent change to use json for notmuch-search.el introduced a bug\r
> in the code for keeping position on refresh. The problem is a\r
> comparison between (plist-get result :thread) and a thread-id returned\r
> by notmuch-search-find-thread-id: the latter is prefixed with\r
> "thread:"\r
>\r
> We fix this by adding an option to notmuch-search-find-thread-id to\r
> return the bare thread-id. It appears that notmuch-search-refresh-view\r
> is the only caller of notmuch-search that supplies a thread-id so this\r
> change should be safe (but could theoretically break users .emacs\r
> functions).\r
> ---\r
>\r
> This is a different version of the bugfix suggested in the parent to\r
> this thread. I think it is nicer but there is a slight risk of breaking\r
> users .emacs lisp functions.\r
>\r
> In general I think the thread: prefix should be present where the term\r
> is "really" a search term, but absent when it is must be a thread-id,\r
> and this fits with that idea.\r
>\r
> With 0.14 freeze pretty close it might be best to apply this to master\r
> and the simpler no breakage option (in id:"87boinpqfg.fsf@qmul.ac.uk")\r
> to the branch.\r
\r
LGTM.\r
\r
IMHO you're too shy with this patch to be included in 0.14 :D\r
-- at least I cannot imagine a case this would fail...\r
\r
My change would have been:\r
  (when thread (if bare thread (concat "thread:" thread)))\r
\r
or even (which changes irrelevant part):\r
  (if thread (if bare thread (concat "thread:" thread)))\r
\r
Anyway, this is good as it is "in the grand scheme of things".\r
\r
Tomi\r
\r
>\r
> Best wishes \r
>\r
> Mark\r
>\r
>  emacs/notmuch.el |   10 ++++++----\r
>  1 files changed, 6 insertions(+), 4 deletions(-)\r
>\r
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
> index d2d82a9..0fff58a 100644\r
> --- a/emacs/notmuch.el\r
> +++ b/emacs/notmuch.el\r
> @@ -475,10 +475,12 @@ BEG."\r
>       (push (plist-get (notmuch-search-get-result pos) property) output)))\r
>      output))\r
>  \r
> -(defun notmuch-search-find-thread-id ()\r
> -  "Return the thread for the current thread"\r
> +(defun notmuch-search-find-thread-id (&optional bare)\r
> +  "Return the thread for the current thread\r
> +\r
> +If BARE is set then do not prefix with \"thread:\""\r
>    (let ((thread (plist-get (notmuch-search-get-result) :thread)))\r
> -    (when thread (concat "thread:" thread))))\r
> +    (when thread (concat (when (not bare) "thread:") thread))))\r
>  \r
>  (defun notmuch-search-find-thread-id-region (beg end)\r
>    "Return a list of threads for the current region"\r
> @@ -993,7 +995,7 @@ same relative position within the new buffer."\r
>    (interactive)\r
>    (let ((target-line (line-number-at-pos))\r
>       (oldest-first notmuch-search-oldest-first)\r
> -     (target-thread (notmuch-search-find-thread-id))\r
> +     (target-thread (notmuch-search-find-thread-id t))\r
>       (query notmuch-search-query-string)\r
>       (continuation notmuch-search-continuation))\r
>      (notmuch-kill-this-buffer)\r
> -- \r
> 1.7.9.1\r
>\r
> _______________________________________________\r
> notmuch mailing list\r
> notmuch@notmuchmail.org\r
> http://notmuchmail.org/mailman/listinfo/notmuch\r