1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 081D5431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 23:52:16 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id MgaPYYuWx9tB for <notmuch@notmuchmail.org>;
\r
17 Fri, 21 Jun 2013 23:52:08 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 0B04D431FAE
\r
22 for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 23:52:08 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1UqHg5-000162-Hl; Sat, 22 Jun 2013 07:52:06 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1UqHg5-0008Sb-8s; Sat, 22 Jun 2013 07:52:05 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v6 02/12] tag-util: do not reset list in
\r
34 parse_tag_command_line
\r
35 In-Reply-To: <1371880008-18312-3-git-send-email-novalazy@gmail.com>
\r
36 References: <1371880008-18312-1-git-send-email-novalazy@gmail.com>
\r
37 <1371880008-18312-3-git-send-email-novalazy@gmail.com>
\r
38 User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Sat, 22 Jun 2013 07:52:02 +0100
\r
41 Message-ID: <87mwqivdrh.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: fbab1e3826fac83e5935b15cb239dec2 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -0.0
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -0.0 points.
\r
53 Summary of the scoring:
\r
54 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
55 provider * (markwalters1009[at]gmail.com)
\r
56 * -0.0 AWL AWL: From: address is in the auto white-list
\r
57 X-QM-Scan-Virus: ClamAV says the message is clean
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sat, 22 Jun 2013 06:52:16 -0000
\r
74 > No current callers of parse_tag_command_line require that it clear its
\r
75 > tag list argument. The notmuch 'insert' command will be better served
\r
76 > if the function modifies a pre-populated list (of new.tags) instead of
\r
77 > clobbering it outright.
\r
79 As far as I can see there is now only 1 caller of
\r
80 parse_tag_command_line. Assuming I am correct can we make this "As the
\r
81 unique current caller of parse_tag_command_line does not require..."
\r
90 > 2 files changed, 2 insertions(+), 2 deletions(-)
\r
92 > diff --git a/tag-util.c b/tag-util.c
\r
93 > index 92e08a1..3bde409 100644
\r
96 > @@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
\r
100 > - tag_op_list_reset (tag_ops);
\r
102 > for (i = 0; i < argc; i++) {
\r
103 > if (strcmp (argv[i], "--") == 0) {
\r
105 > diff --git a/tag-util.h b/tag-util.h
\r
106 > index 246de85..4628f16 100644
\r
109 > @@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
\r
110 > * Output Parameters:
\r
111 > * ops contains a list of tag operations
\r
112 > * query_str the search terms.
\r
114 > + * The ops argument is not cleared.
\r
117 > tag_parse_status_t
\r
121 > _______________________________________________
\r
122 > notmuch mailing list
\r
123 > notmuch@notmuchmail.org
\r
124 > http://notmuchmail.org/mailman/listinfo/notmuch
\r