1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B5227431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 24 Nov 2012 14:09:32 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 20yoziCEfMpT for <notmuch@notmuchmail.org>;
\r
16 Sat, 24 Nov 2012 14:09:32 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 3030A431FAE
\r
20 for <notmuch@notmuchmail.org>; Sat, 24 Nov 2012 14:09:32 -0800 (PST)
\r
21 X-AuditID: 1209190f-b7f636d00000095b-aa-50b1459b63a6
\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])
\r
23 by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 63.84.02395.B9541B05; Sat, 24 Nov 2012 17:09:31 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id qAOM9UiJ024004;
\r
27 Sat, 24 Nov 2012 17:09:31 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAOM9TVt021272
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Sat, 24 Nov 2012 17:09:30 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1TcNui-0005uo-SM; Sat, 24 Nov 2012 17:09:28 -0500
\r
37 Date: Sat, 24 Nov 2012 17:09:28 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: markwalters1009 <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH v2 4/7] emacs: make emacs tagging use the stdin query
\r
42 Message-ID: <20121124220902.GI4562@mit.edu>
\r
43 References: <1353763256-32336-1-git-send-email-markwalters1009@gmail.com>
\r
44 <1353763256-32336-5-git-send-email-markwalters1009@gmail.com>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <1353763256-32336-5-git-send-email-markwalters1009@gmail.com>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1p3tujHAYMZ3eYvVc3ksrt+cyezA
\r
52 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcy6so61YKpAxfMFe1gaGK/wdDFyckgImEjc
\r
53 m/yEGcIWk7hwbz1bFyMXh5DAPkaJ571/mCGcDYwS665+YYJwLjJJnH18igXCWcIocbt3MVAZ
\r
54 BweLgKrEn78WIKPYBDQktu1fzghiiwjoS+xZcZsNxGYWkJb49ruZCcQWFoiUWPagiwXE5hXQ
\r
55 lnh/6TTUtk5Gic7DM1ghEoISJ2c+YYFo1pK48e8lE8gukEHL/3GAhDkFvCS2bn0FVi4qoCIx
\r
56 5eQ2tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXRO93MwSvdSU0k2M
\r
57 4LCW5N/B+O2g0iFGAQ5GJR7exDPrA4RYE8uKK3MPMUpyMCmJ8lY5bQwQ4kvKT6nMSCzOiC8q
\r
58 zUktPsQowcGsJMJrrQqU401JrKxKLcqHSUlzsCiJ815NuekvJJCeWJKanZpakFoEk5Xh4FCS
\r
59 4OUCxq+QYFFqempFWmZOCUKaiYMTZDgP0HATkBre4oLE3OLMdIj8KUZFKXHepy5ACQGQREZp
\r
60 HlwvLO28YhQHekWYlx2knQeYsuC6XwENZgIa/HT2OpDBJYkIKakGxhlnHk1eULBX3cFtn+EF
\r
61 aVduVZfyFelr1YS7i6TPMCrpPmlnZXf+u7JHeO0G7rQ0X/cP8uGRnwuuSDlvyGneOC0/puDc
\r
62 puzp6h/35C5yZda6tkhD9uSJ7FLZ1pe+G9U+hUaaHawIjInQmWWR8PqLVr2okaNOmYn2Pe09
\r
63 KWtqVDf45PLV7f+jxFKckWioxVxUnAgAnKmopxYDAAA=
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Sat, 24 Nov 2012 22:09:32 -0000
\r
79 Quoth markwalters1009 on Nov 24 at 1:20 pm:
\r
80 > From: Mark Walters <markwalters1009@gmail.com>
\r
82 > In preparation for the use of large queries in some cases make tagging
\r
83 > from emacs use the new query on stdin functionality. Currently uses
\r
84 > this for all tagging (as I could not see a reason not to).
\r
86 > emacs/notmuch-tag.el | 14 +++++++++-----
\r
87 > 1 files changed, 9 insertions(+), 5 deletions(-)
\r
89 > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
\r
90 > index 4fce3a9..4634b0d 100644
\r
91 > --- a/emacs/notmuch-tag.el
\r
92 > +++ b/emacs/notmuch-tag.el
\r
93 > @@ -59,9 +59,10 @@ the messages that were tagged"
\r
94 > (setq search-terms (list "*")))
\r
96 > (with-output-to-string
\r
97 > - (with-current-buffer standard-output
\r
98 > - (apply 'call-process notmuch-command nil t
\r
99 > - nil "search" "--output=tags" "--exclude=false" search-terms)))
\r
100 > + (with-temp-buffer
\r
101 > + (insert (mapconcat 'identity search-terms " "))
\r
105 > + (apply 'call-process-region (point-min) (point-max) notmuch-command nil
\r
107 #'call-process-region ?
\r
109 > + standard-output nil "search" "--output=tags" "--exclude=false" (list "-"))))
\r
111 If you use funcall instead of apply here, you won't need to put "-" in
\r
114 Also, the lines seem a little long (but maybe that's just diff and
\r
119 > (defun notmuch-select-tag-with-completion (prompt &rest search-terms)
\r
120 > @@ -134,8 +135,11 @@ notmuch-after-tag-hook will be run."
\r
122 > (unless (null tag-changes)
\r
123 > (run-hooks 'notmuch-before-tag-hook)
\r
124 > - (apply 'notmuch-call-notmuch-process "tag"
\r
125 > - (append tag-changes (list "--" query)))
\r
126 > + (with-temp-buffer
\r
128 > + (apply 'notmuch-call-notmuch-process-region
\r
130 #'notmuch-call-notmuch-process-region ?
\r
132 > + (point-min) (point-max)
\r
133 > + "tag" (append tag-changes (list "--" "-"))))
\r
134 > (run-hooks 'notmuch-after-tag-hook))
\r
135 > ;; in all cases we return tag-changes as a list
\r