1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4C259431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 5 Jul 2014 05:41:38 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OC0R7HBQna0N for <notmuch@notmuchmail.org>;
\r
16 Sat, 5 Jul 2014 05:41:30 -0700 (PDT)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
18 [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D177E431FAF
\r
21 for <notmuch@notmuchmail.org>; Sat, 5 Jul 2014 05:41:29 -0700 (PDT)
\r
22 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
23 4.72) (envelope-from <david@tethera.net>)
\r
24 id 1X3PG6-0005nN-SK; Sat, 05 Jul 2014 12:40:02 +0000
\r
25 Received: (nullmailer pid 23405 invoked by uid 1000); Sat, 05 Jul 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH v2 01/10] lib: add return status to database close and
\r
31 In-Reply-To: <1397653165-15620-2-git-send-email-novalazy@gmail.com>
\r
32 References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>
\r
33 <1397653165-15620-2-git-send-email-novalazy@gmail.com>
\r
34 User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-pc-linux-gnu)
\r
36 Date: Sat, 05 Jul 2014 09:39:43 -0300
\r
37 Message-ID: <871tu0rncg.fsf@maritornes.cs.unb.ca>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Sat, 05 Jul 2014 12:41:38 -0000
\r
54 Peter Wang <novalazy@gmail.com> writes:
\r
56 > From: Jani Nikula <jani@nikula.org>
\r
58 > notmuch_database_close may fail in Xapian ->flush() or ->close(), so
\r
59 > report the status. Similarly for notmuch_database_destroy which calls
\r
62 This patch looks OK, and it makes sense independent of what else
\r
63 follows with respect to notmuch-insert.
\r
65 With respect so SONAME bumping, we might be able to get away with out it
\r
66 here (although that could be un-portable or broken in a way I haven't
\r
67 seen yet), but we can also delay that decision until closer to the next
\r
68 release; I don't think it's as important to provide a stable ABI for
\r
69 people building from git, and I'd prefer to batch ABI changes into one
\r