1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D89DB431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:57 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id l13iMvlKfhdv for <notmuch@notmuchmail.org>;
\r
16 Wed, 18 Apr 2012 06:09:53 -0700 (PDT)
\r
17 Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com
\r
18 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id CB047431FBC
\r
21 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:53 -0700 (PDT)
\r
22 Received: by qcsk26 with SMTP id k26so5587574qcs.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:09:53 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type:x-gm-message-state;
\r
28 bh=b/jhujKXVpQTQt0isqAId3CzYg046PWF0BcCcgV5xFA=;
\r
29 b=ZWPOOQhQi4oZFR6cie+zcStBpVzvj5cLQc4LMegoFEGqWaC/JTSFdYGlqLa42sTrqN
\r
30 YGLl/2+TlDfmhU5P0XwuPwBJyq0HxyYXTDG5NSAlyNrLRcAj1YP+cGgMcJWi0+vQDuv3
\r
31 xhuL3yLbXsD7mBWPY0D3jfTc1wUJE7u0NzEqXMq96VnOHPVbu/9gucFwTzhMO6aZy1Qt
\r
32 vceUhByHowkVBIcz6uLGy3NadjHpy1ybWWJqFccQciun/WWYxZ3ZaM/JNyS531aZ31FE
\r
33 f3H9McGRAvQEFtA5qkROUISQMcIVz82LH4PLJorOhTxFH0mdcFzDwLOqr5+08H2icJk8
\r
35 Received: by 10.229.136.203 with SMTP id s11mr820410qct.38.1334754593140;
\r
36 Wed, 18 Apr 2012 06:09:53 -0700 (PDT)
\r
37 Received: from localhost (nikula.org. [92.243.24.172])
\r
38 by mx.google.com with ESMTPS id gy7sm23801649qab.22.2012.04.18.06.09.51
\r
39 (version=SSLv3 cipher=OTHER); Wed, 18 Apr 2012 06:09:52 -0700 (PDT)
\r
40 From: Jani Nikula <jani@nikula.org>
\r
41 To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
\r
42 Subject: Re: [PATCH v2 2/3] reply: add message-id header
\r
43 In-Reply-To: <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>
\r
44 References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>
\r
45 <1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>
\r
46 User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1
\r
48 Date: Wed, 18 Apr 2012 13:09:50 +0000
\r
49 Message-ID: <87zka9b2zl.fsf@nikula.org>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
53 ALoCoQkaBkIbSXRQRHMKNTOjjiYkzdFGUQ5gpmG1J2tNXWQFzpnkLkOcDPWAUiQtyfZ0zrHDu4mv
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Wed, 18 Apr 2012 13:09:58 -0000
\r
68 On Wed, 18 Apr 2012 15:39:12 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:
\r
69 > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
71 > notmuch-reply.c | 11 +++++++++++
\r
72 > 1 file changed, 11 insertions(+)
\r
74 > diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
75 > index 0949d9f..d796bb2 100644
\r
76 > --- a/notmuch-reply.c
\r
77 > +++ b/notmuch-reply.c
\r
78 > @@ -464,6 +464,8 @@ create_reply_message(void *ctx,
\r
80 > const char *subject, *from_addr = NULL;
\r
81 > const char *in_reply_to, *orig_references, *references;
\r
82 > + const char *message_id;
\r
83 > + char *simple_from;
\r
85 > /* The 1 means we want headers in a "pretty" order. */
\r
86 > GMimeMessage *reply = g_mime_message_new (1);
\r
87 > @@ -488,6 +490,8 @@ create_reply_message(void *ctx,
\r
88 > if (from_addr == NULL)
\r
89 > from_addr = notmuch_config_get_user_primary_email (config);
\r
91 > + simple_from = talloc_strdup (ctx, from_addr);
\r
93 > from_addr = talloc_asprintf (ctx, "%s <%s>",
\r
94 > notmuch_config_get_user_name (config),
\r
96 > @@ -508,6 +512,13 @@ create_reply_message(void *ctx,
\r
97 > g_mime_object_set_header (GMIME_OBJECT (reply),
\r
98 > "References", references);
\r
100 > + message_id = talloc_asprintf (ctx, "<%lu-notmuch-%s>",
\r
104 This duplicates the problem in "notmuch compose", hinting that you
\r
105 should probably have the message-id generation in one place only.
\r
107 I do wonder whether the emacs ui / message mode will add a duplicate
\r
108 message-id rather than override this.
\r
114 > + g_mime_object_set_header (GMIME_OBJECT (reply),
\r
115 > + "Message-ID", message_id);
\r
116 > + talloc_free (simple_from);
\r
124 > _______________________________________________
\r
125 > notmuch mailing list
\r
126 > notmuch@notmuchmail.org
\r
127 > http://notmuchmail.org/mailman/listinfo/notmuch
\r