1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D10AC431E64
\r
6 for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id r8VFieAw9cmv for <notmuch@notmuchmail.org>;
\r
16 Sat, 10 Jan 2015 01:18:24 -0800 (PST)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id A6F34431E62
\r
21 for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:24 -0800 (PST)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1Y9sBc-0002VR-1I; Sat, 10 Jan 2015 05:18:24 -0400
\r
25 Received: (nullmailer pid 8029 invoked by uid 1000); Sat, 10 Jan 2015
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
\r
29 Subject: Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.
\r
30 In-Reply-To: <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>
\r
31 References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu>
\r
32 <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>
\r
33 User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sat, 10 Jan 2015 10:18:18 +0100
\r
36 Message-ID: <87k30vj8o5.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 10 Jan 2015 09:18:28 -0000
\r
53 Jesse Rosenthal <jrosenthal@jhu.edu> writes:
\r
56 > +#define EMPTY_STRING(s) ((s)[0] == '\0')
\r
59 Extra whitespace at end of line. If that's the only issue I can rebase
\r
60 it away, but maybe you want to enable the standard pre-commit hook?
\r
62 > struct visible _notmuch_thread {
\r
63 > notmuch_database_t *notmuch;
\r
65 > @@ -330,11 +332,13 @@ _thread_set_subject_from_message (notmuch_thread_t *thread,
\r
67 > cleaned_subject = talloc_strdup (thread, subject);
\r