1 Return-Path: <aclements@csail.mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EE8B4431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 5 Oct 2014 16:30:02 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id C8gXqMJ-ltjL for <notmuch@notmuchmail.org>;
\r
16 Sun, 5 Oct 2014 16:29:57 -0700 (PDT)
\r
17 Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 5BC1B431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 5 Oct 2014 16:29:57 -0700 (PDT)
\r
20 Received: from [104.131.20.129] (helo=awakeningjr)
\r
21 by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
\r
22 (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)
\r
23 id 1XavFU-0000VZ-Vw; Sun, 05 Oct 2014 19:29:57 -0400
\r
24 Received: from amthrax by awakeningjr with local (Exim 4.84)
\r
25 (envelope-from <aclements@csail.mit.edu>)
\r
26 id 1XavFU-0004fU-N1; Sun, 05 Oct 2014 19:29:56 -0400
\r
27 Date: Sun, 5 Oct 2014 19:29:56 -0400
\r
28 From: Austin Clements <aclements@csail.mit.edu>
\r
29 To: David Bremner <david@tethera.net>
\r
30 Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature
\r
31 Message-ID: <20141005232956.GD7970@csail.mit.edu>
\r
32 References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
\r
33 <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>
\r
34 <87d2a6q4hf.fsf@maritornes.cs.unb.ca>
\r
36 Content-Type: text/plain; charset=us-ascii
\r
37 Content-Disposition: inline
\r
38 In-Reply-To: <87d2a6q4hf.fsf@maritornes.cs.unb.ca>
\r
39 User-Agent: Mutt/1.5.23 (2014-03-12)
\r
40 Cc: notmuch@notmuchmail.org
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Sun, 05 Oct 2014 23:30:03 -0000
\r
55 Quoth David Bremner on Oct 05 at 10:56 am:
\r
56 > Austin Clements <aclements@csail.mit.edu> writes:
\r
57 > > + if (new_features & NOTMUCH_FEATURE_GHOSTS) {
\r
58 > > + t_end = db->metadata_keys_end ("thread_id_");
\r
59 > > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)
\r
63 > It would be nice to have the comment below, or something like it, for
\r
66 /* The ghost message upgrade converts all thread_id_*
\r
67 * metadata values into ghost message documents. */
\r
70 > > + /* Perform metadata upgrades. */
\r
72 > > + /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing
\r
73 > > + * messages were stored as database metadata. Change these to
\r
74 > > + * ghost messages.
\r