1 Return-Path: <wellons@nullprogram.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 500FC431FC7
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Aug 2013 10:08:52 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 X-Amavis-Alert: BAD HEADER SECTION, Improper folded header field made up
\r
9 entirely of whitespace (char 20 hex): X-Spam-Report: ...T_ADDRESS@@
\r
10 for details.\n \n Content previ[...]
\r
14 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
16 Received: from olra.theworths.org ([127.0.0.1])
\r
17 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
18 with ESMTP id 9AfmLlHpbkXi for <notmuch@notmuchmail.org>;
\r
19 Wed, 21 Aug 2013 10:08:46 -0700 (PDT)
\r
20 Received: from mail.nullprogram.com (mail.nullprogram.com [192.241.191.137])
\r
21 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
22 (No client certificate requested)
\r
23 by olra.theworths.org (Postfix) with ESMTPS id EB2B9431FAF
\r
24 for <notmuch@notmuchmail.org>; Wed, 21 Aug 2013 10:08:45 -0700 (PDT)
\r
25 Received: from localhost ([127.0.0.1] helo=wellocc1-ld1.jhuapl.edu)
\r
26 by mail.nullprogram.com with esmtp (Exim 4.80)
\r
27 (envelope-from <wellons@nullprogram.com>)
\r
28 id 1VCBX1-0003PH-Ko; Wed, 21 Aug 2013 16:45:15 +0000
\r
29 From: Christopher Wellons <wellons@nullprogram.com>
\r
30 To: notmuch@notmuchmail.org
\r
31 Subject: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read.
\r
32 Date: Wed, 21 Aug 2013 12:44:48 -0400
\r
33 Message-Id: <1377103488-7425-1-git-send-email-wellons@nullprogram.com>
\r
34 X-Mailer: git-send-email 1.8.4.rc3
\r
35 Cc: Christopher Wellons <wellons@nullprogram.com>
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Wed, 21 Aug 2013 17:08:52 -0000
\r
50 As stated in the Emacs documentation, the initial-input argument is
\r
51 deprecated because it presents a poor interface to the user. In fact,
\r
52 with my setup where ido replaces completing-read, it's nearly unusable
\r
55 http://www.gnu.org/software/emacs/manual/html_node/elisp/Initial-Input.html
\r
57 emacs/notmuch-address.el | 6 +++---
\r
58 1 file changed, 3 insertions(+), 3 deletions(-)
\r
60 diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
\r
61 index fa65cd5..e89200b 100644
\r
62 --- a/emacs/notmuch-address.el
\r
63 +++ b/emacs/notmuch-address.el
\r
64 @@ -42,11 +42,11 @@ to know how address selection is made by default."
\r
65 :group 'notmuch-send
\r
66 :group 'notmuch-external)
\r
68 -(defun notmuch-address-selection-function (prompt collection initial-input)
\r
69 +(defun notmuch-address-selection-function (prompt collection def)
\r
70 "Call (`completing-read'
\r
71 - PROMPT COLLECTION nil nil INITIAL-INPUT 'notmuch-address-history)"
\r
72 + PROMPT COLLECTION nil nil nil 'notmuch-address-history DEF)"
\r
74 - prompt collection nil nil initial-input 'notmuch-address-history))
\r
75 + prompt collection nil nil nil 'notmuch-address-history def))
\r
77 (defvar notmuch-address-message-alist-member
\r
78 '("^\\(Resent-\\)?\\(To\\|B?Cc\\|Reply-To\\|From\\|Mail-Followup-To\\|Mail-Copies-To\\):"
\r