1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D95BF429E3B
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 13:44:54 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id 6nK2x43g60Vl for <notmuch@notmuchmail.org>;
\r
18 Mon, 16 Jan 2012 13:44:54 -0800 (PST)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 15569429E35
\r
23 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 13:44:54 -0800 (PST)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1RmuMG-0008O8-Gy; Mon, 16 Jan 2012 21:44:52 +0000
\r
28 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
30 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
31 (envelope-from <m.walters@qmul.ac.uk>)
\r
32 id 1RmuMG-0001dM-96; Mon, 16 Jan 2012 21:44:52 +0000
\r
33 From: Mark Walters <markwalters1009@gmail.com>
\r
34 To: notmuch@notmuchmail.org
\r
35 Subject: Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as
\r
37 In-Reply-To: <87wr8r5trv.fsf@servo.finestructure.net>
\r
38 References: <1326629796-11436-1-git-send-email-markwalters1009@gmail.com>
\r
39 <1326629796-11436-2-git-send-email-markwalters1009@gmail.com>
\r
40 <87wr8r5trv.fsf@servo.finestructure.net>
\r
41 User-Agent: Notmuch/0.11~rc2+73~g1ea2b60 (http://notmuchmail.org) Emacs/23.3.1
\r
43 Date: Mon, 16 Jan 2012 21:44:51 +0000
\r
44 Message-ID: <87lip7fhkc.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 X-Sender-Host-Address: 94.192.233.223
\r
48 X-QM-SPAM-Info: Sender has good ham record. :)
\r
49 X-QM-Body-MD5: f3908cd95a58dcdd320142c460123eab (of first 20000 bytes)
\r
50 X-SpamAssassin-Score: -1.2
\r
51 X-SpamAssassin-SpamBar: -
\r
52 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
54 spam. We require at least 5.0 points to mark a message as spam.
\r
55 This message scored -1.2 points.
\r
56 Summary of the scoring:
\r
57 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
59 * [138.37.6.40 listed in list.dnswl.org]
\r
60 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
61 provider * (markwalters1009[at]gmail.com)
\r
62 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
64 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
65 * 0.2 AWL AWL: From: address is in the auto white-list
\r
66 X-QM-Scan-Virus: ClamAV says the message is clean
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Mon, 16 Jan 2012 21:44:55 -0000
\r
82 (My apologies, owing to various errors on my part the patch has ended up
\r
83 in a separate thread:
\r
84 id:"1326749910-30437-1-git-send-email-markwalters1009@gmail.com")
\r
86 On Mon, 16 Jan 2012 11:31:16 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
87 > > Keymap on a button is: s for save, v for view and o for view with
\r
88 > > other program. Default (i.e. enter or mouse button) is save but is
\r
89 > > easily configurable e.g. set to view with
\r
90 > > (setq notmuch-show-part-button-default-action 'notmuch-show-part-view-action)
\r
92 > Actually, this should really be a defcustom. Maybe something like this:
\r
94 > (defcustom notmuch-show-part-button-default-action 'notmuch-show-part-button-save
\r
95 > "Default part header button action (on ENTER or mouse click)."
\r
97 > :type '(choice (function :tag "Save part"
\r
98 > :value notmuch-show-part-button-save)
\r
99 > (function :tag "View part"
\r
100 > :value notmuch-show-part-button-view)
\r
101 > (function :tag "View interactively"
\r
102 > :value notmuch-show-part-button-interactively-view))
\r
104 > Unfortunately this isn't quite working right, since it's not setting the
\r
105 > default properly, but if someone can help me figure out what I'm doing
\r
106 > wrong, I think this is at least the right idea.
\r
108 This did not work for me, nor did Austin's suggestion but the following
\r
110 +(defcustom notmuch-show-part-button-default-action 'notmuch-show-part-save-action
\r
111 + "Default part header button action (on ENTER or mouse click)."
\r
113 + :type '(choice (const :tag "Save part"
\r
114 + notmuch-show-part-save-action)
\r
115 + (const :tag "View part"
\r
116 + notmuch-show-part-view-action)
\r
117 + (const :tag "View interactively"
\r
118 + notmuch-show-part-interactively-view-action)))
\r
120 I wonder if the "problem" comes from me doing things in a non-lispy
\r
121 fashion (I am completely new to lisp). Thus
\r
122 notmuch-show-part-button-default-action is a variable that gets passed
\r
123 around rather than a function.
\r
125 > There's a white space at the end of this line, which produces the
\r
126 > following git warning:
\r
128 > Applying: Make buttons for attachments allow viewing as well as saving
\r
129 > /home/jrollins/src/notmuch/git/.git/rebase-apply/patch:96: trailing whitespace.
\r
130 > (defvar notmuch-show-part-button-default-action 'notmuch-show-part-save-action)
\r
131 > warning: 1 line adds whitespace errors.
\r
133 > So if you go with (an improved version of) my defcustom suggestion above
\r
134 > you can kill two birds with one stone:
\r
136 Right I have fixed this as above and think the whitespace is ok now (it
\r
137 passes git diff --check). I intended to send the patch as a reply to
\r
138 this email but it has ended up here:
\r
139 id:"1326749910-30437-1-git-send-email-markwalters1009@gmail.com"
\r