1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 546C4429E5B
\r
6 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 08:26:04 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id x4Um6ujzGT8w for <notmuch@notmuchmail.org>;
\r
16 Tue, 31 Jan 2012 08:26:03 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 94F5A429E25
\r
20 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 08:26:03 -0800 (PST)
\r
21 X-AuditID: 12074423-b7f9c6d0000008c3-d8-4f28161bc839
\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])
\r
23 by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 37.9C.02243.B16182F4; Tue, 31 Jan 2012 11:26:03 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0VGQ2pK029324;
\r
27 Tue, 31 Jan 2012 11:26:02 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0VGQ0oU028485
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Tue, 31 Jan 2012 11:26:02 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RsGW2-0004CC-UT; Tue, 31 Jan 2012 11:25:06 -0500
\r
37 Date: Tue, 31 Jan 2012 11:25:06 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the
\r
42 Message-ID: <20120131162506.GE10898@mit.edu>
\r
43 References: <8762fu4aqt.fsf@qmul.ac.uk>
\r
44 <1327862394-14334-3-git-send-email-markwalters1009@gmail.com>
\r
45 <20120131044352.GZ17991@mit.edu> <87y5soccyi.fsf@qmul.ac.uk>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <87y5soccyi.fsf@qmul.ac.uk>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsUixCmqrSstpuFvsO0Gm8XquTwW12/OZHZg
\r
53 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mn69vsVacIenYnJTM0sDYyNXFyMnh4SAicTx
\r
54 n53MELaYxIV769m6GLk4hAT2MUrMurmFHcLZwCjxdvEpqMxJJomPr75AOUsYJVqn/WEF6WcR
\r
55 UJV4+WA2O4jNJqAhsW3/ckYQW0RAR+L2oQVgcWYBaYlvv5uZQGxhgXCJRX++s4DYvEA1ay/+
\r
56 ZIUYuoJRoufYV3aIhKDEyZlPWCCatSRu/HsJ1MwBNmj5Pw6QMCfQrtWdk9hAbFEBFYkpJ7ex
\r
57 TWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmunlZpbopaaUbmIEBTa7
\r
58 i/IOxj8HlQ4xCnAwKvHw7nyv5i/EmlhWXJl7iFGSg0lJlPe7oIa/EF9SfkplRmJxRnxRaU5q
\r
59 8SFGCQ5mJRHeN6uBynlTEiurUovyYVLSHCxK4rwaWu/8hATSE0tSs1NTC1KLYLIyHBxKErwT
\r
60 RYGGChalpqdWpGXmlCCkmTg4QYbzAA1fAVLDW1yQmFucmQ6RP8Woy9H+dvd5RiGWvPy8VClx
\r
61 3rkgRQIgRRmleXBzYAnpFaM40FvCvCtBqniAyQxu0iugJUxAS54zqIIsKUlESEk1MCZNj+Nq
\r
62 6c+a+Y3d05Y/1Eg4fU5p8zHptec3Zul1f1A3XHDFk32mhyhnXXm74C+2Ca57XXO+XjtZZRyZ
\r
63 LWujdy99Q2bie9mMo3LX35a1XJ11PHodY/bDE+lVwbKaQvtNeB9If92w7Y+wwbV5YY0ep75O
\r
64 Aaax+Mk7JvSrduzO5PJRkBT6mtuhxFKckWioxVxUnAgAsP8KhSMDAAA=
\r
65 Cc: notmuch@notmuchmail.org
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Tue, 31 Jan 2012 16:26:04 -0000
\r
80 Quoth Mark Walters on Jan 31 at 11:45 am:
\r
81 > On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
82 > > Quoth Mark Walters on Jan 29 at 6:39 pm:
\r
83 > > > notmuch_message_node_t *iterator;
\r
86 > > > diff --git a/lib/notmuch.h b/lib/notmuch.h
\r
87 > > > index 7929fe7..740d005 100644
\r
88 > > > --- a/lib/notmuch.h
\r
89 > > > +++ b/lib/notmuch.h
\r
90 > > > @@ -449,6 +449,11 @@ typedef enum {
\r
92 > > > notmuch_query_get_query_string (notmuch_query_t *query);
\r
94 > > > +/* specify whether to results should omit the excluded results rather
\r
95 > > > + * than just marking them excluded */
\r
97 > > > +notmuch_query_set_omit_excluded_messages (notmuch_query_t *query, notmuch_bool_t omit);
\r
100 > > I don't think we should add this API. The library behavior will not
\r
101 > > change for library users that don't use excludes and library users
\r
102 > > that do use excludes should by aware of the excluded flag and do the
\r
103 > > appropriate thing.
\r
105 > > I can see why this is handy in some cases, but I don't think it
\r
106 > > provides enough utility to warrant becoming part of the permanent and
\r
107 > > minimal library interface.
\r
109 > This is really a performance improvement: suppose that there are lots of
\r
110 > threads that only match in excluded messages. Then without this flag we
\r
111 > will spend lots of time constructing the thread only for it to be
\r
112 > ignored. (In contrived situations this could be arbitrarily slower.)
\r
114 I would prefer to keep the public API minimal and only introduce
\r
115 something like this if people actually experience performance
\r