2b/79224a2aac0e2e5e6c98b40e49a563cb786490

   1 Return-Path: <dkg@fifthhorseman.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 20B92431FD0\r
   6         for <notmuch@notmuchmail.org>; Tue, 21 Jun 2011 05:42:47 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id vUIaVqOE4M8S for <notmuch@notmuchmail.org>;\r
  16         Tue, 21 Jun 2011 05:42:46 -0700 (PDT)\r
  17 Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
  18         by olra.theworths.org (Postfix) with ESMTP id BAA5E431FB6\r
  19         for <notmuch@notmuchmail.org>; Tue, 21 Jun 2011 05:42:46 -0700 (PDT)\r
  20 Received: from [192.168.13.75] (lair.fifthhorseman.net [216.254.116.241])\r
  21         by che.mayfirst.org (Postfix) with ESMTPSA id A8EE9F970\r
  22         for <notmuch@notmuchmail.org>; Tue, 21 Jun 2011 08:42:44 -0400 (EDT)\r
  23 Message-ID: <4E0091AE.5070609@fifthhorseman.net>\r
  24 Date: Tue, 21 Jun 2011 08:42:22 -0400\r
  25 From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
  26 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;\r
  27         rv:1.9.2.17) Gecko/20110516 Icedove/3.1.10\r
  28 MIME-Version: 1.0\r
  29 To: notmuch@notmuchmail.org\r
  30 Subject: Re: [PATCH] notmuch-new.c infinite recursion symlink bug\r
  31 References: <20110610073208.GA74787@codecafe.com>\r
  32 In-Reply-To: <20110610073208.GA74787@codecafe.com>\r
  33 X-Enigmail-Version: 1.1.2\r
  34 Content-Type: multipart/signed; micalg=pgp-sha512;\r
  35         protocol="application/pgp-signature";\r
  36         boundary="------------enig025FA00585AEAC79EB1990CB"\r
  37 X-BeenThere: notmuch@notmuchmail.org\r
  38 X-Mailman-Version: 2.1.13\r
  39 Precedence: list\r
  40 Reply-To: notmuch <notmuch@notmuchmail.org>\r
  41 List-Id: "Use and development of the notmuch mail system."\r
  42         <notmuch.notmuchmail.org>\r
  43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  44         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  46 List-Post: <mailto:notmuch@notmuchmail.org>\r
  47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  49         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  50 X-List-Received-Date: Tue, 21 Jun 2011 12:42:47 -0000\r
  51 \r
  52 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)\r
  53 --------------enig025FA00585AEAC79EB1990CB\r
  54 Content-Type: text/plain; charset=UTF-8\r
  55 Content-Transfer-Encoding: quoted-printable\r
  56 \r
  57 On 06/10/2011 03:32 AM, Taylor Carpenter wrote:\r
  58 > If a symlink points to . then there will be an infinite recursion.  The=\r
  59  included patch fixes that.\r
  60 \r
  61 what about a sub-directory that contains a symlink to ".." ?\r
  62 \r
  63 or a directory that contains both:\r
  64 \r
  65  ./a/foo =E2=86=92 ../b\r
  66  ./b/foo =E2=86=92 ../a\r
  67 \r
  68 or ...\r
  69 \r
  70 My point is: there are lots of ways to get infinite recursions via\r
  71 symlinks;  hard-coding a check for one specific way seems like a\r
  72 sub-optimal approach, because it leaves the other paths still present,\r
  73 and introduces an unexpected/surprising asymmetry.\r
  74 \r
  75 I'm not sure what the specific right way is to solve the problem you\r
  76 identified, though.\r
  77 \r
  78         --dkg\r
  79 \r
  80 \r
  81 --------------enig025FA00585AEAC79EB1990CB\r
  82 Content-Type: application/pgp-signature; name="signature.asc"\r
  83 Content-Description: OpenPGP digital signature\r
  84 Content-Disposition: attachment; filename="signature.asc"\r
  85 \r
  86 -----BEGIN PGP SIGNATURE-----\r
  87 Version: GnuPG v1.4.11 (GNU/Linux)\r
  88 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/\r
  89 \r
  90 iQJ8BAEBCgBmBQJOAJGuXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w\r
  91 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRUU1QkU5NzkyODJEODBCOUY3NTQwRjFD\r
  92 Q0QyRUQ5NEQyMTczOUU5AAoJEMzS7ZTSFznpiG0P/jWnLtl/jNUVJVCm7RMI6OOG\r
  93 tzyPL/VvvnHVgdjECDwx5gtsO+7D9udgE1L8lPwwtYZ4C1wn2sSLT5NI3FdXxq4K\r
  94 JVCKWNwXzQndTupqSJHtfDBqZTmGBK22u9yfRXNKfRpm1L9tjAq8htWmWZ5LSmZk\r
  95 4oJoArPwMaGuwrdHr/4LHwPa3Ewqfq5wNxrnBA7KchTSiobAS01ZtZAWnxBSsCXf\r
  96 GbD457GRaHZSDqyY4InlLMHhnxd5GS6erHppHlzD7ADYC287c8HYaS7MddOahzFQ\r
  97 NEIXLMriteIrilurONCwgMEYKWW18dzFijud/IVFMsuWpnvHdIjV/En2LkOF6jDU\r
  98 PDiiA3UisdsP7vMCQ9hnCBaHuo0I6RPSXyCSb9LgoHXWLrCb2OXoRF3JkvjqS8u3\r
  99 qqcpUERIlspWl6hfgGxn4oPxrT9xy3kaXJd3IlaRFP7Qt13/jasc9MR5/N5SjBlD\r
 100 m2wqpVf90m+Rcw6qx5/yuabNfqkWJjCqydofkYzjB7n8l53OgKKY73gHbiOS6x4l\r
 101 0zh4qj3+oLREdCNSACF1ZcXXr2IqXQl0HZQ8tgk/1B6xFD3y5pD/DYJKy/Uebefm\r
 102 7N9EMwa2zlAG9YElitT7wy/RxosWidMXwMALAOUTvuRyVXrt9Sz5CIOpu76MfAS8\r
 103 K9T3G2DEcN6sYMDNuq15\r
 104 =pnpR\r
 105 -----END PGP SIGNATURE-----\r
 106 \r
 107 --------------enig025FA00585AEAC79EB1990CB--\r