1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id ABE9F431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 7 Jul 2012 23:15:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 5MUlXy5FhiDi for <notmuch@notmuchmail.org>;
\r
17 Sat, 7 Jul 2012 23:15:44 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id BB77B431FAE
\r
22 for <notmuch@notmuchmail.org>; Sat, 7 Jul 2012 23:15:43 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SnkmU-0001Uk-8f; Sun, 08 Jul 2012 07:15:42 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SnkmT-0004cQ-R4; Sun, 08 Jul 2012 07:15:41 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Ingo Lohmar <i.lohmar@gmail.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] emacs: Fix notmuch-message-mark-replied.
\r
35 In-Reply-To: <87vcj8ckzm.fsf@acer.localhost.com>
\r
36 References: <87vcj8ckzm.fsf@acer.localhost.com>
\r
37 User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sun, 08 Jul 2012 07:15:38 +0100
\r
40 Message-ID: <87bojqrd6d.fsf@qmul.ac.uk>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-Sender-Host-Address: 94.192.233.223
\r
44 X-QM-SPAM-Info: Sender has good ham record. :)
\r
45 X-QM-Body-MD5: d3bd0b0e81ef06fb708c5da77aea86e1 (of first 20000 bytes)
\r
46 X-SpamAssassin-Score: -1.8
\r
47 X-SpamAssassin-SpamBar: -
\r
48 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
50 spam. We require at least 5.0 points to mark a message as spam.
\r
51 This message scored -1.8 points.
\r
52 Summary of the scoring:
\r
53 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
55 * [138.37.6.40 listed in list.dnswl.org]
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
60 * 0.5 AWL AWL: From: address is in the auto white-list
\r
61 X-QM-Scan-Virus: ClamAV says the message is clean
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Sun, 08 Jul 2012 06:15:45 -0000
\r
76 On Sun, 03 Jun 2012, Ingo Lohmar <i.lohmar@gmail.com> wrote:
\r
77 > notmuch-message-mark-replied used "apply" to change message tags
\r
78 > according to notmuch-message-replied-tags after sending a reply. This
\r
79 > works if the latter is a single-element list. But with the recently
\r
80 > changed format of tag changes, it breaks for multiple-element lists.
\r
81 > Use "funcall" to properly pass the list of tag changes as a single
\r
84 This looks correct to me: the bug is still in current master and this
\r
87 As Jamie says, it would be nice to have a test. Unfortunately, that is
\r
88 beyond my test/emacs skills.
\r
90 Note this bug does not occur with default configuration but the option
\r
91 is a defcustom option, and following the example in that option's
\r
92 documentation will cause the problem.
\r
94 Since this patch has been around for over a month I think it should
\r
95 probably be applied.
\r
102 > emacs/notmuch-message.el | 2 +-
\r
103 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
105 > diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
\r
106 > index 5964caa..d3738bf 100644
\r
107 > --- a/emacs/notmuch-message.el
\r
108 > +++ b/emacs/notmuch-message.el
\r
109 > @@ -45,7 +45,7 @@ the \"inbox\" and \"todo\", you would set
\r
112 > notmuch-message-replied-tags)))
\r
113 > - (apply 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))
\r
114 > + (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))
\r
116 > (add-hook 'message-send-hook 'notmuch-message-mark-replied)
\r
121 > _______________________________________________
\r
122 > notmuch mailing list
\r
123 > notmuch@notmuchmail.org
\r
124 > http://notmuchmail.org/mailman/listinfo/notmuch
\r