1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id AE8766DE01F7
\r
6 for <notmuch@notmuchmail.org>; Tue, 3 May 2016 12:01:58 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.013 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.002, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
\r
14 Received: from arlo.cworth.org ([127.0.0.1])
\r
15 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id AIz00ZAChx2m for <notmuch@notmuchmail.org>;
\r
17 Tue, 3 May 2016 12:01:50 -0700 (PDT)
\r
18 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
\r
19 by arlo.cworth.org (Postfix) with ESMTPS id 25F146DE00DF
\r
20 for <notmuch@notmuchmail.org>; Tue, 3 May 2016 12:01:50 -0700 (PDT)
\r
21 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
\r
22 (envelope-from <david@tethera.net>)
\r
23 id 1axfZl-0004OQ-GZ; Tue, 03 May 2016 15:01:41 -0400
\r
24 Received: (nullmailer pid 17899 invoked by uid 1000);
\r
25 Tue, 03 May 2016 19:01:44 -0000
\r
26 From: David Bremner <david@tethera.net>
\r
27 To: Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org
\r
28 Subject: Re: [PATCH] Use the Xapian::DB_RETRY_LOCK flag when available
\r
29 In-Reply-To: <m38tzr2n6v.fsf@zsu.kismala.com>
\r
30 References: <m38tzr2n6v.fsf@zsu.kismala.com>
\r
31 User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1
\r
32 (x86_64-pc-linux-gnu)
\r
33 Date: Tue, 03 May 2016 16:01:44 -0300
\r
34 Message-ID: <8760uv6k4n.fsf@zancas.localnet>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Tue, 03 May 2016 19:01:58 -0000
\r
51 Istvan Marko <notmuch@kismala.com> writes:
\r
53 > Xapian 1.3 has introduced the DB_RETRY_LOCK flag (Xapian bug
\r
54 > 275). Detect it in configure and use it if available. With this flag
\r
55 > commands that need the write lock will wait for their turn instead of
\r
56 > aborting when it's not immediately available.
\r
58 > configure | 25 ++++++++++++++++++++++++-
\r
59 > lib/database.cc | 5 +++++
\r
60 > 2 files changed, 29 insertions(+), 1 deletion(-)
\r
62 > diff --git a/configure b/configure
\r
63 > index 6231d2b..0c1d5bc 100755
\r
66 > @@ -371,6 +371,21 @@ if [ ${have_xapian} = "1" ]; then
\r
70 > +# DB_RETRY_LOCK is only supported on Xapian > 1.3.2
\r
71 > +have_xapian_db_retry_lock=0
\r
72 > +if [ ${have_xapian} = "1" ]; then
\r
73 > + printf "Checking for Xapian lock retry support... "
\r
74 > + case "${xapian_version}" in
\r
75 > + 0.*|1.[012].*|1.3.[0-2])
\r
76 > + printf "No (only available with Xapian > 1.3.2).\n" ;;
\r
77 > + [1-9]*.[0-9]*.[0-9]*)
\r
78 > + have_xapian_db_retry_lock=1
\r
79 > + printf "Yes.\n" ;;
\r
81 > + printf "Unknown version.\n" ;;
\r
85 First, thanks for writing the patch. I'd completely forgotten about this
\r
86 feature, and it's something pretty important for many notmuch users. I
\r
87 saw you got some good feedback from Jani. As a less urgent comment, what
\r
88 about writing the test in the style of
\r
90 http://article.gmane.org/gmane.mail.notmuch.general/22329
\r
92 I don't know if there's complete concensus on this, but I personally
\r
93 much prefer testing features to versions when possible.
\r