1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2825C431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 2 Aug 2012 03:18:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id XpYVa48P0qyk for <notmuch@notmuchmail.org>;
\r
16 Thu, 2 Aug 2012 03:18:38 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 1A7B2431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 2 Aug 2012 03:18:38 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 2D1D7100372; Thu, 2 Aug 2012 13:18:47 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
24 David Bremner <david@tethera.net>, 683505@bugs.debian.org,
\r
25 Jakub Wilk <jwilk@debian.org>
\r
26 Subject: Re: Bug#683505: notmuch: FTBFS if built twice in a row:
\r
27 unrepresentable changes to source
\r
28 In-Reply-To: <87txwmt2ev.fsf@servo.finestructure.net>
\r
29 References: <20120801103707.GA668@jwilk.net>
\r
30 <87pq7aabl8.fsf@convex-new.cs.unb.ca>
\r
31 <878vdyvdjg.fsf@servo.finestructure.net>
\r
32 <87ipd29tu4.fsf@convex-new.cs.unb.ca>
\r
33 <87txwmt2ev.fsf@servo.finestructure.net>
\r
34 User-Agent: Notmuch/0.13.2+103~g9610d35 (http://notmuchmail.org) Emacs/23.1.1
\r
35 (x86_64-redhat-linux-gnu)
\r
36 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
37 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
38 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
39 Date: Thu, 02 Aug 2012 13:18:47 +0300
\r
40 Message-ID: <m28vdx7g1k.fsf@guru.guru-group.fi>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 Cc: notmuch@notmuchmail.org
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Thu, 02 Aug 2012 10:18:40 -0000
\r
58 On Thu, Aug 02 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
60 > On Wed, Aug 01 2012, David Bremner <david@tethera.net> wrote:
\r
61 >> As I mentioned on IRC, the test only fails on the Debian build machines
\r
62 >> (building in a clean chroot using sbuild is not enough) so it isn't
\r
63 >> really clear how to duplicate the it. Perhaps building in a clean
\r
64 >> virtual machine without networking would do it. For which tests fail,
\r
67 >> https://buildd.debian.org/status/fetch.php?pkg=notmuch&arch=i386&ver=0.13.2-1&stamp=1338740444
\r
69 >> I think the first things to fail are emacs tests. At a wild guess, it
\r
70 >> looks like all of the failing tests are related to emacs.
\r
72 > From a cursory look that does appear to be the case. The non-emacs
\r
73 > tests that are also failing (json and crypto) are using
\r
74 > emacs_deliver_message. Do we have any idea what's going on here?
\r
76 is this related (still in my personal patches pool):
\r
78 diff --git a/test/test-lib.el b/test/test-lib.el
\r
79 index 6271da2..503a130 100644
\r
80 --- a/test/test-lib.el
\r
81 +++ b/test/test-lib.el
\r
83 "Disable yes-or-no-p before executing kill-emacs"
\r
84 (defun yes-or-no-p (prompt) t)))
\r
86 +;; Work around a problem with
\r
87 +;; GNU Emacs 23.1.1 (x86_64-redhat-linux-gnu) of 2011-03-26 on sl6.fnal.gov
\r
88 +;; where get-buffer-process doesn't return nil without (list-processes)
\r
89 +;; (value of delete-exited-process is t)
\r
91 +(if (string= emacs-version "23.1.1")
\r
92 + (defadvice get-buffer-process (before run-list-processes activate)
\r
93 + "run (list-processes) before executing get-buffer-process"
\r
94 + (list-processes)))
\r
96 (defun notmuch-test-wait ()
\r
97 "Wait for process completion."
\r
98 (while (get-buffer-process (current-buffer))
\r
101 I also have a commit message:
\r
103 Subject: [PATCH] test: emacs: run list-processes before get-buffer-process in emacs 23.1.1
\r
105 The function get-buffer-process does not return nil when process has
\r
106 exited in some (if not every) emacs 23.1.1 versions, even the value
\r
107 of delete-exited-process is t. Particularly, GNU Emacs 23.1.1
\r
108 (x86_64-redhat-linux-gnu) of 2011-03-26 on sl6.fnal.gov has this
\r
109 problem -- the execution halts when running emacs tests.
\r
111 In this emacs version, when defadvice is used to run list-processes
\r
112 before get-buffer-process the problem seems to be fixed -- emacs
\r
115 To fix this permanently, this defadvice is added to the starting
\r
116 emacs when emacs-version equals "23.1.1".
\r
120 It took me a while to get tests running on Scientific Linux 6 which
\r
121 has this particular emacs version. I tried all kinds of hacks to get
\r
122 it working -- this works best (or, actually, is the only one that works).
\r
123 I just don't understand why... Maybe the emacs-server -interaction brings
\r
124 some hard-to-spot interferences into equation...
\r
126 In the above 'buildd' output emacs 23.4 is used and therefore this patch
\r
127 in the current format would be no-op there.
\r
129 In the buildd environment, just adding the follwing lines to test/test-lib.el
\r
131 (defadvice get-buffer-process (before run-list-processes activate)
\r
132 "run (list-processes) before executing get-buffer-process"
\r
140 >> I don't think failing the build is the right thing to do, since there
\r
141 >> does not actually seem to be anything wrong with the resulting
\r
142 >> packages. So removing them from Debian because of some problems with
\r
143 >> running the test suite seems a bit extreme. People not using
\r
144 >> notmuch-emacs would probably be especially annoyed ;).
\r
146 > But it also doesn't make much sense to me to run the tests as part of
\r
147 > the build only to ignore the result. How do we know that the failing
\r
148 > tests aren't actually affecting the distributed packages? The emacs
\r
149 > failures could be masking real failures of the emacs interface (which
\r
150 > users of notmuch-emacs would probably also find really annoying!).
\r
153 > _______________________________________________
\r
154 > notmuch mailing list
\r
155 > notmuch@notmuchmail.org
\r
156 > http://notmuchmail.org/mailman/listinfo/notmuch
\r