1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 23368431E64
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 01:24:35 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id fbDMnvyht7IF for <notmuch@notmuchmail.org>;
\r
17 Wed, 1 Feb 2012 01:24:34 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 61FE1431FAF
\r
22 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 01:24:34 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so904577bke.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 01:24:33 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=NQZ8wf6habitkxauYKQb4H/MG/3o418apUz6rqtRj6Q=;
\r
29 b=b5Ilvd23cFwKsvyEqlBMJ2wGr2U6ADyoAQyYLruElMos6i90ag4moaeA3SG+ub/wRP
\r
30 IJjmPgmE+zl36jXQEINMkwfIUL0+IiL1hhBNz4mf785FbAS7flynEKCAKJX7ZodPHF5r
\r
31 a9kOaTSVBthGCPygMDzBG9fpgzhGx8dU0f+kg=
\r
32 Received: by 10.204.143.131 with SMTP id v3mr12630437bku.83.1328088272966;
\r
33 Wed, 01 Feb 2012 01:24:32 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id bw9sm52575167bkb.8.2012.02.01.01.24.31
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 01 Feb 2012 01:24:32 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>,
\r
40 Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
\r
42 In-Reply-To: <m28vknaq5l.fsf@guru.guru-group.fi>
\r
43 References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <87r4yfszx9.fsf@servo.finestructure.net>
\r
45 <m28vknaq5l.fsf@guru.guru-group.fi>
\r
46 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Wed, 01 Feb 2012 13:23:19 +0400
\r
49 Message-ID: <87mx92nbzs.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Wed, 01 Feb 2012 09:24:35 -0000
\r
66 On Wed, 01 Feb 2012 10:55:50 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
67 > On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
68 > > On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
69 > > > The down side of this approach is that diff argument order depends on
\r
70 > > > test_expect_equal_file() argument order. So sometimes we get diff
\r
71 > > > from expected to actual results, and sometimes the other way around.
\r
72 > > > But the files are always named correctly.
\r
74 > > Actually, I think this last point is the most important thing to retain.
\r
75 > > Consistency in the diffs makes reading test results much more efficient.
\r
76 > > The order I don't much care about. But seeing as we have been
\r
77 > > consistent with a particular order for a while, it seems like more
\r
78 > > effort than it's worth to change it.
\r
80 > how about enforcing it in the test suite ?
\r
83 > *.expected|*.EXPECTED) ;;
\r
84 > *) echo "$file2" does not end with 'expected' >&2; exit 1
\r
88 It would break some existing tests. But I like it.
\r