1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1F5C7431FCB
\r
6 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 14:42:21 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id u1hw+8cjpkqz for <notmuch@notmuchmail.org>;
\r
16 Thu, 30 Oct 2014 14:42:13 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 21CD6431FC2
\r
19 for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 14:42:13 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.7])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id B8A205CCFD4;
\r
22 Thu, 30 Oct 2014 22:42:11 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP STYX AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,
\r
27 with ESMTP id 5JGoEgklQqgv; Thu, 30 Oct 2014 22:42:07 +0100 (CET)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 9D8F55CCFD1;
\r
30 Thu, 30 Oct 2014 22:42:07 +0100 (CET)
\r
31 Received: from wsh by steelpick.2x.cz with local (Exim 4.84)
\r
32 (envelope-from <sojkam1@fel.cvut.cz>)
\r
33 id 1XjxTm-0005zv-2s; Thu, 30 Oct 2014 22:42:02 +0100
\r
34 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
35 To: Tomi Ollila <tomi.ollila@iki.fi>,
\r
36 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
37 Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to filter out
\r
39 In-Reply-To: <m2zjceueg4.fsf@guru.guru-group.fi>
\r
40 References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
\r
41 <1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
\r
42 <87egtqug4t.fsf@qmul.ac.uk> <m2zjceueg4.fsf@guru.guru-group.fi>
\r
43 User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1
\r
44 (x86_64-pc-linux-gnu)
\r
45 Date: Thu, 30 Oct 2014 22:42:02 +0100
\r
46 Message-ID: <871tppck0l.fsf@steelpick.2x.cz>
\r
48 Content-Type: text/plain
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Thu, 30 Oct 2014 21:42:21 -0000
\r
63 On Thu, Oct 30 2014, Tomi Ollila wrote:
\r
64 > On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
66 >> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
67 >>> This adds an algorithm to filter out duplicate addresses from address
\r
68 >>> outputs (sender, receivers). The algorithm can be configured with
\r
69 >>> --filter-by command line option.
\r
71 >>> The code here is an extended version of a patch from Jani Nikula.
\r
75 >> As this is getting into the more controversial bike shedding region I
\r
76 >> wonder if it would be worth splitting this into 2 patches: the first
\r
77 >> could do the default dedupe based on name/address and the second could
\r
78 >> do add the filter-by options.
\r
80 >> I think the default deduping is obviously worth doing but I am not sure
\r
81 >> about the rest. In any case I think the default deduping could go in
\r
82 >> pre-freeze but I would recommend the rest is left until after.
\r
84 > I can agree with that, but there is one hard thing to resolve:
\r
85 > "naming things"(*)
\r
87 > (*) http://martinfowler.com/bliki/TwoHardThings.html
\r
89 > With all rest ignored (sorry no time to work on this in more detail now),
\r
90 > this default deduping could be done with single argument '--unique'...
\r
92 I would agree that --unique is slightly better than --filter-by, but I
\r
93 don't see what is so attractive on having no deduplication at all.
\r
94 Anyway, I'll keep it in v5 as it is now and we can add
\r
95 --unique=no/none/whatever later.
\r