24/d3c0ba8fee1956667a6768835393bdc870d78d

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 42759431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:35:04 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id nqG3oMKmEGR5 for <notmuch@notmuchmail.org>;\r
  16         Wed, 25 Apr 2012 06:35:02 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
  18         [18.9.25.14])\r
  19         by olra.theworths.org (Postfix) with ESMTP id C22C0431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:35:02 -0700 (PDT)\r
  21 X-AuditID: 1209190e-b7f7c6d0000008c3-5a-4f97fd859577\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 61.79.02243.58DF79F4; Wed, 25 Apr 2012 09:35:01 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q3PDZ0W9032751; \r
  27         Wed, 25 Apr 2012 09:35:00 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3PDYvBh007920\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Wed, 25 Apr 2012 09:34:59 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SN2Mz-0001e4-Nx; Wed, 25 Apr 2012 09:34:57 -0400\r
  37 From: Austin Clements <amdragon@MIT.EDU>\r
  38 To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions\r
  40 In-Reply-To:\r
  41  <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  42 References: <20120422180159.GG17810@mit.edu>\r
  43         <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  44 User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1\r
  45         (i486-pc-linux-gnu)\r
  46 Date: Wed, 25 Apr 2012 09:34:57 -0400\r
  47 Message-ID: <87r4vcgcji.fsf@awakening.csail.mit.edu>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6notv6d7q/wfwueYvZrT+YLK7fnMns\r
  52         wOQx8fxpNo9nq24xBzBFcdmkpOZklqUW6dslcGWcbf3EXPCXtWLtjY9MDYz/WboYOTkkBEwk\r
  53         3px9zQhhi0lcuLeerYuRi0NIYB+jxPf+NVDOBkaJbfu/M0E4J5kkfl9qYoFwljBKLJu7lw2k\r
  54         n01AA6hqOdgsEQE/iVcP5zCB2MICHhI7ru0Bi3MKBEnMOfMFzBYSKJKYvvoemC0qEC/xp3cz\r
  55         0BwODhYBVYmVqwJAwrxA5x3ZsIsFwhaUODnzCZjNLKAlcePfS6YJjAKzkKRmIUktYGRaxSib\r
  56         klulm5uYmVOcmqxbnJyYl5dapGusl5tZopeaUrqJERSSnJJ8Oxi/HlQ6xCjAwajEwzt77zR/\r
  57         IdbEsuLK3EOMkhxMSqK8h39N9xfiS8pPqcxILM6ILyrNSS0+xCjBwawkwvviJVCONyWxsiq1\r
  58         KB8mJc3BoiTOq6b1zk9IID2xJDU7NbUgtQgmK8PBoSTByw8yVLAoNT21Ii0zpwQhzcTBCTKc\r
  59         B2j4UpAa3uKCxNzizHSI/ClGRSlx3pKfQAkBkERGaR5cLyxlvGIUB3pFmNcOpIoHmG7gul8B\r
  60         DWYCGvwtaBrI4JJEhJRUA+OqIF72+Xu+vHnO/GUq+7UepfMX1dvDzZaZidn1R7bODF21dKXS\r
  61         J/9zbEy7hRWvbYxsXLY32XsSc5iWRr7naY3yxqUlHX07niw2PL/pBUfysgO3nHb1a0ZFVXoK\r
  62         BpwMvzrd/1+9hrKTxd20qXEZiS+z5iVdqPp8IehNhGTt1HmXNz+v93JndlZiKc5INNRiLipO\r
  63         BADU44xF9AIAAA==\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Wed, 25 Apr 2012 13:35:04 -0000\r
  77 \r
  78 LGTM.\r
  79 \r
  80 On Wed, 25 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:\r
  81 > Formerly notmuch_database_close closed the xapian database and\r
  82 > destroyed the talloc structure associated with the notmuch database\r
  83 > object. Split notmuch_database_close into notmuch_database_close and\r
  84 > notmuch_database_destroy.\r
  85 >\r
  86 > This makes it possible for long running programs to close the xapian\r
  87 > database and thus release the lock associated with it without\r
  88 > destroying the data structures obtained from it.\r
  89 >\r
  90 > This also makes the api more consistent since every other data\r
  91 > structure has a destructor function.\r
  92 >\r
  93 > The comments in notmuch.h are a courtesy of Austin Clements.\r
  94 >\r
  95 > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r