1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7EB4B40A2BC
\r
6 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:20 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id uNKwvZN9g6gh for <notmuch@notmuchmail.org>;
\r
16 Fri, 24 Feb 2012 14:35:19 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 9F5ED409F00
\r
21 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:19 -0800 (PST)
\r
22 Received: by werp13 with SMTP id p13so2017659wer.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 14:35:18 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of pieter@praet.org designates
\r
25 10.181.11.227 as permitted sender) client-ip=10.181.11.227;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of pieter@praet.org
\r
28 designates 10.181.11.227 as permitted sender)
\r
29 smtp.mail=pieter@praet.org
\r
30 Received: from mr.google.com ([10.181.11.227])
\r
31 by 10.181.11.227 with SMTP id el3mr8855363wid.18.1330122918473
\r
32 (num_hops = 1); Fri, 24 Feb 2012 14:35:18 -0800 (PST)
\r
33 Received: by 10.181.11.227 with SMTP id el3mr7119811wid.18.1330122918390;
\r
34 Fri, 24 Feb 2012 14:35:18 -0800 (PST)
\r
35 Received: from localhost ([109.131.181.26])
\r
36 by mx.google.com with ESMTPS id m16sm14684643wie.9.2012.02.24.14.35.17
\r
37 (version=TLSv1/SSLv3 cipher=OTHER);
\r
38 Fri, 24 Feb 2012 14:35:17 -0800 (PST)
\r
39 From: Pieter Praet <pieter@praet.org>
\r
40 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
41 David Bremner <david@tethera.net>
\r
42 Subject: Re: [PATCH 1/6] test: emacs: new tests "notmuch-show: {add,
\r
43 remove} multiple tags {to, from} single message"
\r
44 In-Reply-To: <87ipiwjz85.fsf@gmail.com>
\r
45 References: <878vjtqhcg.fsf@praet.org>
\r
46 <1330038554-10347-1-git-send-email-pieter@praet.org>
\r
47 <87ipiwjz85.fsf@gmail.com>
\r
48 User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-unknown-linux-gnu)
\r
50 Date: Fri, 24 Feb 2012 23:33:03 +0100
\r
51 Message-ID: <87aa47euao.fsf@praet.org>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
55 ALoCoQnq4jDapgrWi38sBuho1ryjumNwatItN+GsxTHv8e7ef73v+l4zSHT9FC8WEzWT3rxmjhzG
\r
56 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Fri, 24 Feb 2012 22:35:20 -0000
\r
71 On Fri, 24 Feb 2012 14:35:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
75 > > - Rename subtests "{Add,Remove} tag from notmuch-show view" to
\r
76 > > "notmuch-show: {add,remove} single tag {to,from} single message"
\r
77 > > to be consistent with the following tests.
\r
79 > > - New subtest "notmuch-show: add multiple tags to single message":
\r
80 > > `notmuch-show-add-tag' ("+") can add multiple tags to a message.
\r
82 > > - New subtest "notmuch-show: remove multiple tags from single message":
\r
83 > > `notmuch-show-remove-tag' ("-") can remove multiple tags from a message.
\r
86 > Would be nice to have another patch that moves notmuch-show tests to
\r
90 TL;DR: It's on my todo list.
\r
92 Yeah, the Emacs test series *as a whole* desperately needs some
\r
93 reorganizing, not in the least because it's still severely
\r
94 lacking in coverage.
\r
96 Some more structure/consistency would considerably increase the
\r
97 feasibility (or at least reduce the PITAness...) of filling in
\r
98 the numerous blanks and reducing duplication of effort (regarding
\r
99 both hard- and wetware based cycles), as well as increasing the
\r
100 likelihood that developers (not looking in any specific direction)
\r
101 serve their code with a side dish of tests.
\r
103 Ideally (IMHO), it would be split up into separate files by mode,
\r
104 i.e. `notmuch-hello', `notmuch-search', `notmuch-show',
\r
105 `notmuch-{message,mua}', and those can be further divided into
\r
106 sections like navigation, tagging, visibility stuff, hooks, ...
\r
108 There's probably quite a number of implicit interdependencies that
\r
109 need to be taken care of though, and I (as well as others) still
\r
110 have a bunch of tests waiting to be applied, so we might want to do
\r
117 > > test/emacs | 16 ++++++++++++++--
\r
118 > > 1 files changed, 14 insertions(+), 2 deletions(-)
\r
120 > > diff --git a/test/emacs b/test/emacs
\r
121 > > index b74cfa9..ec1dbb0 100755
\r
122 > > --- a/test/emacs
\r
123 > > +++ b/test/emacs
\r
124 > > @@ -112,18 +112,30 @@ test_emacs "(notmuch-search \"$os_x_darwin_thread\")
\r
125 > > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
126 > > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
\r
128 > > -test_begin_subtest "Add tag from notmuch-show view"
\r
129 > > +test_begin_subtest "notmuch-show: add single tag to single message"
\r
130 > > test_emacs "(notmuch-show \"$os_x_darwin_thread\")
\r
131 > > (execute-kbd-macro \"+tag-from-show-view\")"
\r
132 > > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
133 > > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)"
\r
135 > > -test_begin_subtest "Remove tag from notmuch-show view"
\r
136 > > +test_begin_subtest "notmuch-show: remove single tag from single message"
\r
137 > > test_emacs "(notmuch-show \"$os_x_darwin_thread\")
\r
138 > > (execute-kbd-macro \"-tag-from-show-view\")"
\r
139 > > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
140 > > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
\r
142 > > +test_begin_subtest "notmuch-show: add multiple tags to single message"
\r
143 > > +test_emacs "(notmuch-show \"$os_x_darwin_thread\")
\r
144 > > + (execute-kbd-macro \"+tag1-from-show-view +tag2-from-show-view\")"
\r
145 > > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
146 > > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag1-from-show-view tag2-from-show-view unread)"
\r
148 > > +test_begin_subtest "notmuch-show: remove multiple tags from single message"
\r
149 > > +test_emacs "(notmuch-show \"$os_x_darwin_thread\")
\r
150 > > + (execute-kbd-macro \"-tag1-from-show-view -tag2-from-show-view\")"
\r
151 > > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)
\r
152 > > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"
\r
154 > > test_begin_subtest "Message with .. in Message-Id:"
\r
155 > > add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'
\r
156 > > test_emacs '(notmuch-search "id:\"123..456@example\"")
\r
projects / notmuch-archives.git / blob