1 Return-Path: <jan.n.klug@rub.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7877C431FCB
\r
6 for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:04:01 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.138 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id DevVVvE22vgC for <notmuch@notmuchmail.org>;
\r
17 Sat, 24 Jan 2015 09:03:58 -0800 (PST)
\r
18 X-Greylist: delayed 401 seconds by postgrey-1.32 at olra;
\r
19 Sat, 24 Jan 2015 09:03:57 PST
\r
20 Received: from mx6.rz.ruhr-uni-bochum.de (mi.ruhr-uni-bochum.de
\r
22 by olra.theworths.org (Postfix) with SMTP id EB83A431FAE
\r
23 for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 09:03:57 -0800 (PST)
\r
24 X-Queued: (qmail 3693 invoked by alias); 24 Jan 2015 16:57:16 -0000
\r
25 X-RUB-Notes: Internal
\r
26 X-Queued: (qmail 3615 invoked by uid 108); 24 Jan 2015 16:57:15 -0000
\r
27 X-Qmailscanner: from 134.147.42.227 by mx6.rz.ruhr-uni-bochum.de
\r
28 (envelope-from <jan.n.klug@rub.de>,
\r
29 uid 102) with qmail-scanner-2.01 (clamdscan: 0.98.1/18526.
\r
30 Clear:RC:1(134.147.42.227):.
\r
31 Processed in 0.076136 secs); 24 Jan 2015 16:57:15 -0000
\r
32 Received: from mail1.mail.ruhr-uni-bochum.de (134.147.42.227)
\r
33 by mx6.rz.ruhr-uni-bochum.de with SMTP; 24 Jan 2015 16:57:15 -0000
\r
34 Received: from localhost (mobil-13.rubion.ruhr-uni-bochum.de [134.147.65.233])
\r
35 by mail1.mail.ruhr-uni-bochum.de (Postfix) with ESMTPSA id A5C37200E2
\r
36 for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 17:57:14 +0100 (CET)
\r
37 Date: Sat, 24 Jan 2015 17:56:39 +0100
\r
38 From: "Jan N. Klug" <jan.n.klug@rub.de>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 2/3] notmuch-mutt: support for messages that lack
\r
42 Message-ID: <20150124165639.GA1316@mobil-13.rubion.rub.de>
\r
43 References: <1422090701-19385-1-git-send-email-zack@upsilon.cc>
\r
44 <1422090701-19385-3-git-send-email-zack@upsilon.cc>
\r
45 <871tmkql6j.fsf@nikula.org> <20150124152106.GA23037@upsilon.cc>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <20150124152106.GA23037@upsilon.cc>
\r
50 User-Agent: Mutt/1.5.23 (2014-03-12)
\r
51 X-Virus-Scanned: clamav-milter 0.98.5 at mail1.mail.ruhr-uni-bochum.de
\r
52 X-Virus-Status: Clean
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Sat, 24 Jan 2015 17:04:01 -0000
\r
67 On Sat, Jan 24, 2015 at 04:21:06PM +0100, Stefano Zacchiroli wrote:
\r
68 > On Sat, Jan 24, 2015 at 04:59:16PM +0200, Jani Nikula wrote:
\r
69 > > On Sat, 24 Jan 2015, Stefano Zacchiroli <zack@upsilon.cc> wrote:
\r
70 > > > To do the above, rewrite get_message_id() to scan the current message
\r
71 > > > line by line, incrementally computing a SHA1. As a consequence, drop
\r
72 > > > the dependency on Mail::Internet.
\r
74 > > I am not so sure this is a good idea however, see below.
\r
76 > But I didn't think of header folding, and you're absolutely correct in
\r
77 > saying that might be a problem.
\r
79 I disagree. I do not think that header folding is a problem here. RFC
\r
80 5322 and RFC 2822 state that FWS in the message-id are not allowed (as
\r
81 opposed to In-Reply: and other headers, where FWS may occur between, but
\r
82 not inside message-ids).
\r
84 Folded lines that start with "Message-Id:" might occur, the
\r
85 regex-pattern used in the patch will not match those lines.
\r
87 As far as I have looked in the Mail::Internet sources, further checking of the
\r
88 correctness of the message-id does not occur, so I do not see any
\r
89 advantage over the proposed solution.
\r
91 > Jan: do you agree with using Mail::Header->new and fall back to
\r
92 > line-by-line hasing only in case Message-ID is not found? If so, having
\r
93 > an updated patch based on the one I've posted here would be awesome! If
\r
94 > you cannot do that just let me know and I'll get to it, eventually :).
\r
96 I can look into that, but I cannot promise to have it ready in the next
\r
103 Jan N. Klug, Gelsenkirchen
\r