1 Return-Path: <aaronecay@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6C0D1431FD0
\r
6 for <notmuch@notmuchmail.org>; Mon, 25 Jul 2011 16:39:14 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id bWaU7-NhdKOG for <notmuch@notmuchmail.org>;
\r
17 Mon, 25 Jul 2011 16:39:13 -0700 (PDT)
\r
18 Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com
\r
19 [209.85.216.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 89B8B431FB6
\r
22 for <notmuch@notmuchmail.org>; Mon, 25 Jul 2011 16:39:13 -0700 (PDT)
\r
23 Received: by qyk29 with SMTP id 29so1344358qyk.5
\r
24 for <notmuch@notmuchmail.org>; Mon, 25 Jul 2011 16:39:12 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;
\r
27 bh=ZI0UrmyViIlvuiC+9YeBIhm0Wl482jGqE2t9n90wP3U=;
\r
28 b=xxEn2PSH+U8c2OlqGhPbdR/yoESNWp4fH1lxvvquZhbGXRVRoshCPF0Xk0jvMjcJMa
\r
29 mnnbLiKyAcKrf/1qDVdumZppSab34tOzf44BRoDxDqBTLzydkHJLcYuIDT4ScR0Jqj9I
\r
30 4iMePbFf7lJ2Qjo8eJiOqQ+4yOlMcvrtoG17k=
\r
31 Received: by 10.229.221.65 with SMTP id ib1mr3494080qcb.258.1311637152697;
\r
32 Mon, 25 Jul 2011 16:39:12 -0700 (PDT)
\r
33 Received: from localhost.localdomain (vpl025.wlan.library.upenn.edu
\r
35 by mx.google.com with ESMTPS id k5sm2038118qct.45.2011.07.25.16.39.10
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Mon, 25 Jul 2011 16:39:11 -0700 (PDT)
\r
38 From: Aaron Ecay <aaronecay@gmail.com>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: [PATCH] Add missing call to g_type_init()
\r
41 Date: Mon, 25 Jul 2011 19:38:58 -0400
\r
42 Message-Id: <1311637138-13963-1-git-send-email-aaronecay@gmail.com>
\r
43 X-Mailer: git-send-email 1.7.6
\r
44 In-Reply-To: <87bowiccax.fsf@servo.factory.finestructure.net>
\r
45 References: <87bowiccax.fsf@servo.factory.finestructure.net>
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Mon, 25 Jul 2011 23:39:14 -0000
\r
60 The Glib docs state "Prior to any use of the type system, g_type_init() has to
\r
61 be called".[1] To not do so can lead to segfaults. The g_type system is
\r
62 currently used by various "filters" that operate on uuencoded text, message
\r
65 [1] http://developer.gnome.org/gobject/2.28/gobject-Type-Information.html#g-type-init
\r
69 I have added a link to the Glib docs to the commit message, and a description
\r
70 of where the type code is used. There isn't an easy way to test for this bug,
\r
71 I think -- not including the init call is wrong by the API docs, but only
\r
72 sometimes yields a crash.
\r
75 1 files changed, 1 insertions(+), 0 deletions(-)
\r
77 diff --git a/notmuch.c b/notmuch.c
\r
78 index 3973e35..f9d6629 100644
\r
81 @@ -579,6 +579,7 @@ main (int argc, char *argv[])
\r
82 local = talloc_new (NULL);
\r
88 return notmuch (local);
\r