1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AC6D6431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 03:13:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id KElanK3ioeNG for <notmuch@notmuchmail.org>;
\r
16 Wed, 28 Mar 2012 03:13:13 -0700 (PDT)
\r
17 Received: from mail-qa0-f43.google.com (mail-qa0-f43.google.com
\r
18 [209.85.216.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 0B381431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 03:13:12 -0700 (PDT)
\r
22 Received: by qadb15 with SMTP id b15so65804qad.2
\r
23 for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 03:13:11 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=s/SUtTxS+CPuJpgn5wFWhbZVztV2lNSgRaAU3br7GCY=;
\r
29 b=AThIi7JYIoIWRCSmag+afBVujuuiHjjclV0AYQMfdC8TL67PECFSwLHObJqQLmDmGH
\r
30 pf474ghp0Wm+IGQrLve+lWh6LlEULoz25+0fLPzzuYbm3drPLsomr39zbg5H7WEzwH8r
\r
31 fifuhFmkPRmAOSSCjmz0GRlDXP4ByzUi/9B5R4u9CiqHwJLapjk6uHogTKQa2Fq8N7Yf
\r
32 ht7u90uBrOh4gYQwniVpn53l7koIuZ+1aaVDhtDpc8ggIq3zO6VhviXtzbKYEgY/D1K1
\r
33 5s4L0PX/s60BJ6px/OwtuxjvTWfhaY2jAA8fPIYj7B/Ix9C8ymVcShLBST4IgbXpmCxF
\r
35 Received: by 10.229.136.79 with SMTP id q15mr11033220qct.149.1332929591203;
\r
36 Wed, 28 Mar 2012 03:13:11 -0700 (PDT)
\r
37 Received: from localhost (nikula.org. [92.243.24.172])
\r
38 by mx.google.com with ESMTPS id j17sm5755831qaj.9.2012.03.28.03.13.08
\r
39 (version=SSLv3 cipher=OTHER); Wed, 28 Mar 2012 03:13:10 -0700 (PDT)
\r
40 From: Jani Nikula <jani@nikula.org>
\r
41 To: Notmuch Mail <notmuch@notmuchmail.org>
\r
42 Subject: Re: bug in emacs reply code?
\r
43 In-Reply-To: <87r4we3wp7.fsf@nikula.org>
\r
44 References: <87r4we3wp7.fsf@nikula.org>
\r
45 User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1
\r
47 Date: Wed, 28 Mar 2012 10:13:05 +0000
\r
48 Message-ID: <87obrh3ufi.fsf@nikula.org>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
52 ALoCoQkTd6s8BDCjknQPNVYpCE0boE9uaC0/Y+ijZPe7F4MuOxHOWRHpZPpP8+i1Uvc8Bw922/aZ
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Wed, 28 Mar 2012 10:13:17 -0000
\r
67 On Tue, 27 Mar 2012 15:11:48 +0000, Jani Nikula <jani@nikula.org> wrote:
\r
69 > Hi all, just upgraded from 0.11 to master on one machine, and emacs
\r
70 > reply started failing as follows. The four tests fail, all others pass.
\r
75 I bisected the problem to commit "emacs: Use the new JSON reply format
\r
76 and message-cite-original" 650123510cfa64caf6b20f5239f43433fa6f2941.
\r
78 Following up Adam's suggestion, it boils down to a change in emacs
\r
79 message-mail function in lisp/gnus/message.el. If I eval-defun the
\r
80 message-mail from 23.3, the UI seems to work. The diff between the
\r
81 versions is below. That bit of elisp is beyond me, please look into it.
\r
86 --- emacs-23.2/lisp/gnus/message.el 2010-04-23 17:59:51.000000000+0300
\r
87 +++ emacs-23.3/lisp/gnus/message.el 2011-11-26 05:20:20.000000000+0200
\r
89 @@ -6487,7 +6513,13 @@
\r
92 `((To . ,(or to "")) (Subject . ,(or subject "")))
\r
93 - (when other-headers other-headers))
\r
94 + ;; C-h f compose-mail says that headers should be specified as
\r
95 + ;; (string . value); however all the rest of message expects
\r
96 + ;; headers to be symbols, not strings (eg message-header-format-alist).
\r
97 + ;; http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00337.html
\r
98 + ;; We need to convert any string input, eg from rmail-start-mail.
\r
99 + (dolist (h other-headers other-headers)
\r
100 + (if (stringp (car h)) (setcar h (intern (capitalize (car h)))))))
\r
101 yank-action send-actions continue switch-function)
\r
102 ;; FIXME: Should return nil if failure.
\r
104 @@ -8189,5 +8221,4 @@
\r