1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 438A9421192
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 06:22:49 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id b24d-r4bZgb7 for <notmuch@notmuchmail.org>;
\r
17 Wed, 1 Feb 2012 06:22:48 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 74B42429E5B
\r
22 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 06:22:48 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so1210308bke.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 06:22:47 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=p+ua8PV7E+yJZnmN6UGFJ6pObshfJln/6WSNpKCVxO0=;
\r
29 b=vzcmcxzl9hiEIoy7pe6hRtT/Wp87KghnQeq82jc3Sp4PalATgklRkIzQ7qeGUfC29K
\r
30 tloqotLRxelbBs3F6ZJgW0YmPXf73M8l1GOPheWSBzNGBvkQitAzdCCnRpWxJ92ENgwf
\r
31 f+GECcNdK4FIM2bleIpcNTDqsdhvtcqHa6IvU=
\r
32 Received: by 10.205.124.15 with SMTP id gm15mr13158948bkc.63.1328106166962;
\r
33 Wed, 01 Feb 2012 06:22:46 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id o26sm48807015bko.14.2012.02.01.06.22.45
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 01 Feb 2012 06:22:46 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Pieter Praet <pieter@praet.org>, David Edmondson <dme@dme.org>,
\r
40 David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>
\r
41 Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn
\r
42 ..." with "(when ..."
\r
43 In-Reply-To: <874nva7jkk.fsf@praet.org>
\r
44 References: <87k44uprvy.fsf@praet.org>
\r
45 <1326532638-22068-1-git-send-email-pieter@praet.org>
\r
46 <87y5ssxam7.fsf@zancas.localnet>
\r
47 <CAB+hUn-GmONr24nfxBkt59TzHHyZiD1wioYXoPh9wy-rZR-m2g@mail.gmail.com>
\r
48 <87ty3fycje.fsf@zancas.localnet>
\r
49 <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>
\r
50 <874nva7jkk.fsf@praet.org>
\r
51 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
52 (x86_64-pc-linux-gnu)
\r
53 Date: Wed, 01 Feb 2012 18:21:33 +0400
\r
54 Message-ID: <87bopimy6q.fsf@gmail.com>
\r
56 Content-Type: text/plain; charset=us-ascii
\r
57 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Wed, 01 Feb 2012 14:22:49 -0000
\r
72 On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
73 > On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:
\r
74 > > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:
\r
75 > > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
76 > > > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
\r
78 > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional
\r
79 > > > > change, and the big non-functional indentation change it caused,
\r
80 > > > > separately. Would you prefer (or tolerate ;) that style?
\r
82 > > > Hmm, that might be nicer, I'm not 100% sure.
\r
84 > > > I wouldn't say it's mandatory for a patch like this (and I'd say other
\r
85 > > > peoples views on what's easy to review are at least as important as mine
\r
88 > > Each patch should be valid in the repository without any following
\r
89 > > patches (preceding are obviously okay). Incorrect indentation would
\r
90 > > disqualify a patch from being 'valid', so it shouldn't be accepted.
\r
94 > Indentation corrections should always be part of the same patch as
\r
95 > the change(s) that invalidated the indentation in the first place.
\r
97 > Spotting the *actual* (non-indentation) changes is a non-issue
\r
98 > when using `diff-refine-hunk' (or a wrapper thereof [1]).
\r
101 Must... resist... getting... into... this...
\r