1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E64EE431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 5 Apr 2012 04:56:31 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yNhlAexuinJ2 for <notmuch@notmuchmail.org>;
\r
16 Thu, 5 Apr 2012 04:56:31 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 3121E431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 5 Apr 2012 04:56:31 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
25 (Exim 4.72) (envelope-from <bremner@unb.ca>)
\r
26 id 1SFlIj-0000js-Iz; Thu, 05 Apr 2012 08:56:29 -0300
\r
27 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
28 (envelope-from <bremner@unb.ca>)
\r
29 id 1SFlIe-0000yj-8y; Thu, 05 Apr 2012 08:56:24 -0300
\r
30 From: David Bremner <bremner@unb.ca>
\r
31 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 3/8] hex-escape: add function to decode escaped string
\r
35 <026815054d3e01e6f29c0834d43ccabdf6eda481.1333231401.git.jani@nikula.org>
\r
36 References: <cover.1333231401.git.jani@nikula.org>
\r
37 <026815054d3e01e6f29c0834d43ccabdf6eda481.1333231401.git.jani@nikula.org>User-Agent: Notmuch/0.12+70~g46e73fe (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Thu, 05 Apr 2012 08:56:24 -0300
\r
40 Message-ID: <87d37mtms7.fsf@zancas.localnet>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Thu, 05 Apr 2012 11:56:32 -0000
\r
58 Jani Nikula <jani@nikula.org> writes:
\r
60 > Add function hex_decode_inplace() to decode the input string onto
\r
63 > Signed-off-by: Jani Nikula <jani@nikula.org>
\r
67 > This could be folded to "hex-escape: (en|de)code strings to/from
\r
68 > restricted character set".
\r
70 Probably. It's a bit hard to follow as is; somehow the code movement is
\r
75 > if (*p == escape_char) {
\r
77 unrelated whitespace changes, naughty naughty.
\r
80 > +hex_decode_inplace (char *p)
\r
82 > + return hex_decode_internal (p, (unsigned char *) p);
\r
83 this could probably use a comment to the effect that there _will_ be
\r
88 > + q = (unsigned char *) *out;
\r
90 I understand trying to minimize changes, but do p and q serve any
\r
94 > + return hex_decode_internal (p, q);
\r
99 > + * Decode 'in' onto itself.
\r
102 This is just a bit terse for my taste.
\r