1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B7778431FBF
\r
6 for <notmuch@notmuchmail.org>; Mon, 21 Apr 2014 13:26:30 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id XItTH6wh9Zy0 for <notmuch@notmuchmail.org>;
\r
16 Mon, 21 Apr 2014 13:26:23 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8535C431FBD
\r
19 for <notmuch@notmuchmail.org>; Mon, 21 Apr 2014 13:26:23 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 7407A10008C;
\r
22 Mon, 21 Apr 2014 23:26:14 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 00/11] Improve charset and cid: handling
\r
26 In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu>
\r
27 References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>
\r
28 User-Agent: Notmuch/0.17+201~g56da2d6 (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Mon, 21 Apr 2014 23:26:14 +0300
\r
34 Message-ID: <m2eh0qtont.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Mon, 21 Apr 2014 20:26:30 -0000
\r
51 On Mon, Apr 21 2014, Austin Clements <amdragon@MIT.EDU> wrote:
\r
53 > I set out to quickly add support for cid: links in the shr renderer
\r
54 > and wound up making our charset handling more robust and rewriting our
\r
55 > content-ID handling. The test introduced in patch 2 passes in all but
\r
56 > one really obscure case, but only because of many unwritten and
\r
57 > potentially fragile assumptions that Emacs and the CLI make about each
\r
60 > The first three patches could reasonably go in to 0.18. The rest of
\r
61 > this series is certainly post-0.18, but I didn't want to lose track of
\r
64 Patches 1-3 looks good and tests pass. I've also (suffessfully) used
\r
65 this 'no-conversion (although I don't remember why ;/ -- this conversion
\r
66 stuff is not something simple to comprehend...)
\r
68 So, +1 for getting 1-3 to 0.18.
\r
74 > This series comes in three stages. Each depends on the earlier ones,
\r
75 > but each prefix makes sense on its own and could be pushed without the
\r
78 > Patch 1 is a simple clean up patch.
\r
80 > Patches 2 through 7 robust-ify our charset handling in Emacs, mostly
\r
81 > by splitting the broken `notmuch-get-bodypart-content' API into
\r
82 > `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a
\r
83 > caller can explicitly convey their requirements.
\r
85 > The remaining patches improve our content-ID handling and add support
\r
86 > for cid: links for shr.
\r
88 > _______________________________________________
\r
89 > notmuch mailing list
\r
90 > notmuch@notmuchmail.org
\r
91 > http://notmuchmail.org/mailman/listinfo/notmuch
\r