1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 67E26431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 11:21:03 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id nIF+CPc0iWO6 for <notmuch@notmuchmail.org>;
\r
16 Thu, 19 Jan 2012 11:21:02 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id ADE04431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 11:21:02 -0800 (PST)
\r
22 Received: by werp13 with SMTP id p13so279138wer.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 11:21:01 -0800 (PST)
\r
24 Received: by 10.180.83.72 with SMTP id o8mr40993494wiy.22.1327000861417;
\r
25 Thu, 19 Jan 2012 11:21:01 -0800 (PST)
\r
26 Received: from localhost ([109.131.97.13])
\r
27 by mx.google.com with ESMTPS id dr7sm26565783wib.3.2012.01.19.11.20.59
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 19 Jan 2012 11:21:00 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Austin Clements <amdragon@MIT.EDU>
\r
32 Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions
\r
33 Date: Thu, 19 Jan 2012 20:19:00 +0100
\r
34 Message-Id: <1327000744-25463-1-git-send-email-pieter@praet.org>
\r
35 X-Mailer: git-send-email 1.7.8.1
\r
36 In-Reply-To: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
\r
37 References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
\r
38 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Thu, 19 Jan 2012 19:21:03 -0000
\r
53 Nice feature! I won't be using it myself, but I can imagine it being
\r
54 *very* useful for those who still feel the need to "delete" email :).
\r
59 - All other config-related functions and args include the section title
\r
60 in their name [1], so for the sake of consistency, we might want to
\r
61 mirror that. Also, the "auto"matic part is pretty much a given.
\r
63 So I'd like to suggest replacing all occurences of "auto_exclude_tags"
\r
64 with "search_exclude_tags" (and simply "exclude_tags" in the args to
\r
65 `_config_get_list' and `_config_set_list', of course).
\r
67 Unfortunately, this would also partially invalidate your recent NEWS
\r
70 - If the 'search.exclude_tags' option is missing from the config file,
\r
71 its value is automatically set to "deleted;spam;", which probably isn't
\r
72 a sane default. Luckily, you've already provided the solution [3].
\r
74 - To make new users aware of the config option's existence, we should
\r
75 prompt them to configure it during setup.
\r
83 [1] Eg. `notmuch_config_get_user_name', `notmuch_config_get_new_tags',
\r
84 `notmuch_config_get_maildir_synchronize_flags', ...
\r
86 [2] id:"1326920330-31496-1-git-send-email-amdragon@mit.edu"
\r
88 [3] id:"20120117203211.GQ16740@mit.edu"
\r