1b/4fc1af8bc590afde0e7315068f48814fe4b3dd

   1 Return-Path: <wking@tremily.us>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2512F431FC0\r
   6         for <notmuch@notmuchmail.org>; Mon, 22 Sep 2014 10:00:01 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.1\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id LAbHfIG1WLmX for <notmuch@notmuchmail.org>;\r
  17         Mon, 22 Sep 2014 09:59:57 -0700 (PDT)\r
  18 Received: from resqmta-po-05v.sys.comcast.net (resqmta-po-05v.sys.comcast.net\r
  19         [96.114.154.164])\r
  20         (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
  21         (No client certificate requested)\r
  22         by olra.theworths.org (Postfix) with ESMTPS id 29A9D431FB6\r
  23         for <notmuch@notmuchmail.org>; Mon, 22 Sep 2014 09:59:57 -0700 (PDT)\r
  24 Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232])\r
  25         by resqmta-po-05v.sys.comcast.net with comcast\r
  26         id uGyT1o006516pyw01GzvlS; Mon, 22 Sep 2014 16:59:55 +0000\r
  27 Received: from odin.tremily.us ([24.18.63.50])\r
  28         by resomta-po-08v.sys.comcast.net with comcast\r
  29         id uGzu1o00a152l3L01GzuA1; Mon, 22 Sep 2014 16:59:55 +0000\r
  30 Received: by odin.tremily.us (Postfix, from userid 1000)\r
  31         id 6574A13A74B5; Mon, 22 Sep 2014 09:59:54 -0700 (PDT)\r
  32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
  33         t=1411405194; bh=/IxcCaEY7mm7iOULiiwQDy7izpMnJDuHwvick5cS5B4=;\r
  34         h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
  35         b=O0aVxTmXaVsXtyz91gbJ+3ZToO4gaNooGyFRQZ2ZdnGupi9T8NsShaQ0ueGtQGTn5\r
  36         3P2+nUGU6WyFI1iXZnInFxA80nOF0d7iLYRyPnJ3TCPoXxIqEyt6zPhMHrsNLviVXH\r
  37         sDx6BC/9I54xzrEoBM4Uog0kliKwgy/PMBTN++wc=\r
  38 Date: Mon, 22 Sep 2014 09:59:54 -0700\r
  39 From: "W. Trevor King" <wking@tremily.us>\r
  40 To: Austin Clements <amdragon@mit.edu>\r
  41 Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section\r
  42 Message-ID: <20140922165954.GI20827@odin.tremily.us>\r
  43 References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: multipart/signed; micalg=pgp-sha1;\r
  46         protocol="application/pgp-signature"; boundary="zgY/UHCnsaNnNXRx"\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
  49 OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
  50         url=http://tremily.us/pubkey.txt\r
  51 User-Agent: Mutt/1.5.23 (2014-03-12)\r
  52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
  53         s=q20140121; t=1411405195;\r
  54         bh=2bO80aFKD78S5G4i+hKBP/ZqERuWDCPzP+ylWiXiBoU=;\r
  55         h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
  56         MIME-Version:Content-Type;\r
  57         b=luaN6xdDIZyZmEGiW5ByHpmlR8W/JmkAq25OZ9GlWmtVbKHjmlggfAJJpFsIHwK09\r
  58         vpRYTj4pRF+YgAucrB4YmKJF5TLvRrCYGadNTCXg+9BTI8JEtt/seFSa+xODCTWrxz\r
  59         2H3Qt8Bg2F1iRwIu1fnkjcqBUsBinlCcRCIsQvc+G55zqptrYs7xg8zaMMTmDYYWzL\r
  60         AsyXIlLr33XbrpM1BzKVpInZABYTSlSf0OTgT4tJlAJB2f+tpw1xnTsDJENFBYTyPZ\r
  61         FDqG89JUg+AP/iqejOchJZPD7g/s5xZ7YY0REldkDhTTNKLxDubmekVk17NcO/TnDf\r
  62         p2CvaoIgyEhnQ==\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Mon, 22 Sep 2014 17:00:01 -0000\r
  77 \r
  78 \r
  79 --zgY/UHCnsaNnNXRx\r
  80 Content-Type: text/plain; charset=us-ascii\r
  81 Content-Disposition: inline\r
  82 Content-Transfer-Encoding: quoted-printable\r
  83 \r
  84 On Mon, Sep 22, 2014 at 11:43:35AM -0400, Austin Clements wrote:\r
  85 > This patch simplifies notmuch_database_close to just call\r
  86 > Database::close.  This works for both read-only and read/write\r
  87 > databases, takes care of committing changes, unifies the exception\r
  88 > handling path, and codifies aborting outstanding transactions.\r
  89 \r
  90 If we're dropping the flush call here, where will it be triggered\r
  91 instead?  We'll need to flush/commit our changes to the database at\r
  92 some point before closing.  Do clients now need an explicit\r
  93 flush/commit command (explicit, client-initiated flushes sound like a\r
  94 good idea to me).\r
  95 \r
  96 Cheers,\r
  97 Trevor\r
  98 \r
  99 --=20\r
 100 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
 101 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
 102 \r
 103 --zgY/UHCnsaNnNXRx\r
 104 Content-Type: application/pgp-signature; name="signature.asc"\r
 105 Content-Description: OpenPGP digital signature\r
 106 \r
 107 -----BEGIN PGP SIGNATURE-----\r
 108 Version: GnuPG v2\r
 109 \r
 110 iQIcBAEBAgAGBQJUIFWJAAoJEG8/JgBt8ol8cAkP/jGJGVE54E2keqkqx1uevBic\r
 111 Zb/RQMyr7uC88m9qLKl6PQpnEhHYcRZzGxl4W6nYv58T08+nqb0n1mLDdim0Elsf\r
 112 0BiVo8ou6p6u2NEJzpsyN9n7ZeDujzv0AzaBk/Nof++ZskHU+jxg6QLE8UMbYYKK\r
 113 xC+OBtEaNYmyDjdmNU7/sSQVW6E6y2q1WiWDgsRoX7nJxCA7UVR0tVT2I4t9Dg+M\r
 114 tUUyhnvivRKligUIM/Bqhvtbnh951y9BLWfCMfErqnmK3Q70GvN8nmlljJ83aTHT\r
 115 qrKuGr+uUqQt6qd2KVbEsrw3BmdzRLxCUsmQhQHFfvCh5Dvdi06LkqAheBB72BXV\r
 116 rHCZnefeJz75N1DF6ZLh13A/WfJDIqp7kwoHA1aaTI6QsLApXxHhMFe/n4cMCkOz\r
 117 b/sUI6K4/WgECLcp3vIDDvcjFpxDOapzPZYitdO3ljScsOBIwsRLF5h1+GsLZHFT\r
 118 jiUXlP4+sCkQD24Oi4RKYMKu43DZ1D6MirE9eYf+QlKb8ilUi3/cMxSb2uBTbRV1\r
 119 iI7YesYfViOKLT6Gp9hlEaKKlkPJ5SogFA4bpJSkwVEXJSibzx0af/p13yXrOUMh\r
 120 hG1nDY8A1/gd4okABLJ/+73QlQb2RYFkOFqWUrKBca7akLyVdOBZDqJ00LnFPsmW\r
 121 05U/jwDZI1rCzawoPH30\r
 122 =lmZL\r
 123 -----END PGP SIGNATURE-----\r
 124 \r
 125 --zgY/UHCnsaNnNXRx--\r