1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4EB67431FD0
\r
6 for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:06 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id EWs+5uph38Qw for <notmuch@notmuchmail.org>;
\r
16 Mon, 31 Oct 2011 15:08:05 -0700 (PDT)
\r
17 Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com
\r
18 [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 9E29C431FB6
\r
21 for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:05 -0700 (PDT)
\r
22 Received: by faai28 with SMTP id i28so6781851faa.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 31 Oct 2011 15:08:04 -0700 (PDT)
\r
24 Received: by 10.223.14.3 with SMTP id e3mr32907327faa.25.1320098884201;
\r
25 Mon, 31 Oct 2011 15:08:04 -0700 (PDT)
\r
26 Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi.
\r
28 by mx.google.com with ESMTPS id j5sm40493434faf.14.2011.10.31.15.08.01
\r
29 (version=SSLv3 cipher=OTHER); Mon, 31 Oct 2011 15:08:03 -0700 (PDT)
\r
30 From: Jani Nikula <jani@nikula.org>
\r
31 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
32 notmuch@notmuchmail.org
\r
33 Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in
\r
35 In-Reply-To: <87fwi86dky.fsf@servo.finestructure.net>
\r
36 References: <cover.1320093940.git.jani@nikula.org>
\r
37 <87fwi86dky.fsf@servo.finestructure.net>
\r
38 User-Agent: Notmuch/0.9+44~ga312b1d (http://notmuchmail.org) Emacs/23.3.1
\r
40 Date: Tue, 01 Nov 2011 00:07:59 +0200
\r
41 Message-ID: <87obwwlsqo.fsf@nikula.org>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 Cc: amdragon@mit.edu
\r
45 X-BeenThere: notmuch@notmuchmail.org
\r
46 X-Mailman-Version: 2.1.13
\r
48 List-Id: "Use and development of the notmuch mail system."
\r
49 <notmuch.notmuchmail.org>
\r
50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
53 List-Post: <mailto:notmuch@notmuchmail.org>
\r
54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
57 X-List-Received-Date: Mon, 31 Oct 2011 22:08:06 -0000
\r
59 On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
60 > Hi, Jani. Thanks for working on this. This should also be valuable for
\r
63 Thanks for your interest! :)
\r
65 > In order to push forward with this, though, I think we really need to
\r
66 > have a complete unit test for this new functionality. We usually like
\r
67 > to see units tests that describe and then test for the new functionality
\r
68 > you wish to add, followed by the patches that provide the new
\r
69 > functionality. Lots of good tests for new functionality being proposed
\r
70 > here shouldn't be too difficult to work out ahead of time.
\r
72 Right. I'd just like to make sure the approach I've taken (particularly
\r
73 patch 1 in the set as it touches the lib) is acceptable before spending
\r
74 time on testing and documentation etc. Indeed patches 1 and 2 changed
\r
75 fundamentally between v1 and v2 after some chats on IRC. If the comments
\r
76 now are favourable, I'll write the tests and documentation. (Though I
\r
77 guess I have to admit the tests would've been beneficial to me already
\r