1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 13BEF429E42
\r
6 for <notmuch@notmuchmail.org>; Fri, 16 Aug 2013 13:27:29 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id M8eADsbr+jKt for <notmuch@notmuchmail.org>;
\r
16 Fri, 16 Aug 2013 13:27:21 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 02889429E3A
\r
19 for <notmuch@notmuchmail.org>; Fri, 16 Aug 2013 13:27:20 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id C22BC100051;
\r
22 Fri, 16 Aug 2013 23:27:14 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jani Nikula <jani@nikula.org>, Austin Clements <amdragon@MIT.EDU>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH v3 0/3] Clean up reply's encoding story
\r
27 In-Reply-To: <87fvu93ahu.fsf@nikula.org>
\r
28 References: <1376667343-10863-1-git-send-email-amdragon@mit.edu>
\r
29 <87fvu93ahu.fsf@nikula.org>
\r
30 User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Fri, 16 Aug 2013 23:27:14 +0300
\r
36 Message-ID: <m2mwohwfdp.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Fri, 16 Aug 2013 20:27:29 -0000
\r
53 On Fri, Aug 16 2013, Jani Nikula <jani@nikula.org> wrote:
\r
55 > On Fri, 16 Aug 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
56 >> This is v3 of id:1376587658-19202-1-git-send-email-amdragon@mit.edu.
\r
57 >> This addresses Jani's comment in id:87k3jl3ehe.fsf@nikula.org by
\r
58 >> treating errors while retrieving the original message's References
\r
59 >> header as if the original message didn't have a References header. It
\r
60 >> also adds a comment suggested by Jani on IRC. The diff from v2 is
\r
63 > The series LGTM, and I in particular welcome the diffstat in patch 3!
\r
65 The series LGTM, and I in particular welcome the diffstat in patch 3!
\r
75 >> diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
76 >> index bfd0f51..ac46d02 100644
\r
77 >> --- a/notmuch-reply.c
\r
78 >> +++ b/notmuch-reply.c
\r
79 >> @@ -31,6 +31,7 @@ show_reply_headers (GMimeMessage *message)
\r
80 >> stream_stdout = g_mime_stream_file_new (stdout);
\r
81 >> if (stream_stdout) {
\r
82 >> g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
\r
83 >> + /* Output RFC 2822 formatted (and RFC 2047 encoded) headers. */
\r
84 >> g_mime_object_write_to_stream (GMIME_OBJECT(message), stream_stdout);
\r
85 >> g_object_unref(stream_stdout);
\r
87 >> @@ -526,14 +527,15 @@ create_reply_message(void *ctx,
\r
88 >> "In-Reply-To", in_reply_to);
\r
90 >> orig_references = notmuch_message_get_header (message, "references");
\r
91 >> - if (orig_references) {
\r
92 >> - references = talloc_asprintf (ctx, "%s%s%s",
\r
93 >> - *orig_references ? orig_references : "",
\r
94 >> - *orig_references ? " " : "",
\r
96 >> - g_mime_object_set_header (GMIME_OBJECT (reply),
\r
97 >> - "References", references);
\r
99 >> + if (!orig_references)
\r
100 >> + /* Treat errors like missing References headers. */
\r
101 >> + orig_references = "";
\r
102 >> + references = talloc_asprintf (ctx, "%s%s%s",
\r
103 >> + *orig_references ? orig_references : "",
\r
104 >> + *orig_references ? " " : "",
\r
106 >> + g_mime_object_set_header (GMIME_OBJECT (reply),
\r
107 >> + "References", references);
\r
113 >> _______________________________________________
\r
114 >> notmuch mailing list
\r
115 >> notmuch@notmuchmail.org
\r
116 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r