1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B800A429E25
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 00:34:54 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id AHdEYsj60U71 for <notmuch@notmuchmail.org>;
\r
17 Thu, 12 Jan 2012 00:34:54 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id DE400431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 00:34:53 -0800 (PST)
\r
23 Received: by bkat2 with SMTP id t2so1291509bka.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 00:34:52 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:content-transfer-encoding;
\r
28 bh=MZH0+gmFkgHtz8k0B5cbNBFfOs2fBrMGAM+lEWp70OA=;
\r
29 b=SnN6j3AjW+Rz95JQ2PqSWtY3HoJr6NvkAEjpEgRm3cqqrk1gdI3Zp0eZTDaViN+4G9
\r
30 +rWjBjQP7bGCOFuGdCaNmQk1lbFuX1G3kE+gzKu+f2Qp6LQEh9Ltgb6wq5eKc4ayqezN
\r
31 e/BnlAYt7Ivet05FG7svhcwgpjhLWi3pOFE44=
\r
32 Received: by 10.204.152.219 with SMTP id h27mr783918bkw.75.1326357291257;
\r
33 Thu, 12 Jan 2012 00:34:51 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id gg11sm9145304bkc.9.2012.01.12.00.34.49
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Thu, 12 Jan 2012 00:34:49 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Adam Wolfe Gordon <awg@xvx.ca>, David Edmondson <dme@dme.org>
\r
40 Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
\r
42 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
\r
43 References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
\r
44 <1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
\r
45 <cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>
\r
46 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
\r
47 User-Agent: Notmuch/0.10.2+135~gb811a3c (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Thu, 12 Jan 2012 12:33:58 +0400
\r
50 Message-ID: <87k44xgw09.fsf@gmail.com>
\r
52 Content-Type: text/plain; charset=utf-8
\r
53 Content-Transfer-Encoding: quoted-printable
\r
54 Cc: notmuch@notmuchmail.org
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Thu, 12 Jan 2012 08:34:55 -0000
\r
71 On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon <awg@xvx.ca> wrote:
\r
74 > Thanks for the review. Most of the things you've suggested are easy
\r
75 > changes, and I think obvious improvements, so I'll change them for the
\r
76 > next version. A bit of discussion on the more involved things below:
\r
78 > On Mon, Jan 9, 2012 at 01:50, David Edmondson <dme@dme.org> wrote:
\r
79 > > On Sun, =C2=A08 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon <awg+notmuch=
\r
81 > >> +(defun w3m-region (start end)) ;; From `w3m.el'.
\r
82 > >> +(defun notmuch-mua-quote-part (part)
\r
83 > >> + =C2=A0(with-temp-buffer
\r
84 > >> + =C2=A0 =C2=A0(insert part)
\r
85 > >> + =C2=A0 =C2=A0(message-mode)
\r
86 > >> + =C2=A0 =C2=A0(fill-region (point-min) (point-max))
\r
87 > >> + =C2=A0 =C2=A0(goto-char (point-min))
\r
88 > >> + =C2=A0 =C2=A0(perform-replace "^" "> " nil t nil)
\r
89 > >> + =C2=A0 =C2=A0(set-buffer-modified-p nil)
\r
90 > >> + =C2=A0 =C2=A0(buffer-substring (point-min) (point-max))))
\r
92 > > Couldn't all of this be done directly in the reply buffer?
\r
94 > Indeed, it could, I just hadn't thought of it. I'll do this for the
\r
97 > > Using w3m means that you should `require' it. What happens when a user
\r
98 > > doesn't have it? (Either the elisp or the command.)
\r
100 > This was my initial thought, but when I looked at notmuch-show.el,
\r
101 > which uses w3m features, I noticed that it doesn't have a require. To
\r
102 > be clear, this patch requires w3m.el (not just the w3m binary), which
\r
103 > I don't think anything else in notmuch does.
\r
105 > In the previous version I had a customize variable specifying whether
\r
106 > to quote HTML parts, which meant that if the user could set the
\r
107 > customize variable to false and everything would work without w3m.el.
\r
108 > I'd like not to introduce a new prerequisite, so if there's a way to
\r
109 > make w3m.el optional that would be my preference. Can you provide
\r
110 > some guidance on this?
\r
113 I did not follow the rest of the discussion, so sorry if I missed
\r
114 something obvious. But why can't we render HTML parts in replies the
\r
115 same way we do in notmuch-show (using `mm-display-part')? That should
\r
116 not introduce a w3m.el requirement, would use the same renderer as
\r
117 configured for show and hence would produce consistent output in show
\r
124 > Adam Wolfe Gordon
\r
125 > _______________________________________________
\r
126 > notmuch mailing list
\r
127 > notmuch@notmuchmail.org
\r
128 > http://notmuchmail.org/mailman/listinfo/notmuch
\r