1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17F4A431FBD
\r
6 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 09:34:48 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 5RfQtks94255 for <notmuch@notmuchmail.org>;
\r
17 Sat, 25 Jan 2014 09:34:40 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D1B95431FBC
\r
22 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 09:34:39 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1W777i-0003An-LB; Sat, 25 Jan 2014 17:34:32 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1W776p-00073r-9V; Sat, 25 Jan 2014 17:33:31 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
33 Subject: Re: automatic database upgrades (was: Re: [PATCH 0/7] cli: notmuch
\r
35 In-Reply-To: <87lhy4f6pr.fsf@nikula.org>
\r
36 References: <cover.1390163335.git.jani@nikula.org> <87ppnga21o.fsf@qmul.ac.uk>
\r
37 <87lhy4f6pr.fsf@nikula.org>
\r
38 User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Sat, 25 Jan 2014 17:32:04 +0000
\r
41 Message-ID: <87fvoc9dd7.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-Geographic: According to ripencc,
\r
46 this message was delivered by a machine in Britain (UK) (GB).
\r
47 X-QM-SPAM-Info: Sender has good ham record. :)
\r
48 X-QM-Body-MD5: fad9b9e59c7a2386aac17b9357b9d26b (of first 20000 bytes)
\r
49 X-SpamAssassin-Score: 0.0
\r
50 X-SpamAssassin-SpamBar: /
\r
51 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
53 spam. We require at least 5.0 points to mark a message as spam.
\r
54 This message scored 0.0 points. Summary of the scoring:
\r
55 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
56 provider * (markwalters1009[at]gmail.com)
\r
57 * 0.0 AWL AWL: From: address is in the auto white-list
\r
58 X-QM-Scan-Virus: ClamAV says the message is clean
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sat, 25 Jan 2014 17:34:48 -0000
\r
74 Thanks for posting this. You are quite right about it being orthogonal
\r
75 to this series so a clear +1 from me for the series.
\r
77 What about a config option? Something like
\r
78 database_auto_upgrade=true/false? I wouldn't have a strong preference
\r
79 which was the default (though I would choose "false" in my own
\r
80 config). I guess we would need a command line --upgrade to allow people
\r
81 with database_auto_upgrade=false to do force/allow the upgrade.
\r
94 On Sat, 25 Jan 2014, Jani Nikula <jani@nikula.org> wrote:
\r
95 > On Sat, 25 Jan 2014, Mark Walters <markwalters1009@gmail.com> wrote:
\r
96 >> This series LGTM.
\r
98 > Hi Mark, thanks for the review!
\r
100 >> I do now recall there was some discussion on irc about the automatic
\r
101 >> database upgrade: it would be good to have that documented but the
\r
102 >> consensus was to do it, so +1 from me.
\r
104 > Here's some summary, as promised. Please bear in mind that the
\r
105 > discussion is pretty much irrelevant to this particular patch
\r
106 > series. (We might discuss whether a warning about upgrade should be
\r
107 > printed to stderr also with --quiet, but IMHO that can be a follow-up
\r
110 > A database upgrade is required when the user upgrades to a new version
\r
111 > of notmuch that has a modified database schema. See
\r
112 > id:cover.1389304779.git.jani@nikula.org for an example of a proposed
\r
115 > A database upgrade is a rare event. Most of the time, it's okay to go
\r
116 > back and forth with notmuch versions on the same database, but a
\r
117 > database upgrade is an irreversible process after which the user must
\r
118 > use the new version of notmuch. To go back requires a full rebuild of
\r
121 > We don't have recent experience with the database upgrades. The last
\r
122 > time it happened was before notmuch 0.1 (yes, 0.1) was released, when
\r
123 > the whole upgrade mechanism was introduced:
\r
125 > commit 909f52bd8c4bdfa11cd3e75e3d0959e0293689bd
\r
126 > Author: Carl Worth <cworth@cworth.org>
\r
127 > Date: Thu Jan 7 18:26:31 2010 -0800
\r
129 > lib: Implement versioning in the database and provide upgrade function.
\r
131 > Some of the points in favor of requiring manual intervention (such as
\r
132 > running 'notmuch new --upgrade' or a new command 'notmuch upgrade')
\r
133 > before upgrading the database:
\r
135 > * The database upgrade is an irreversible process. The user should have
\r
136 > a chance to decide whether to go ahead with that. You can't go back to
\r
137 > the old notmuch and database version without rebuilding the database.
\r
139 > * The user should be given the chance to make backups first in case
\r
140 > something goes wrong.
\r
142 > * The database upgrade might take a long time for large databases. The
\r
143 > user should be able to choose when to go ahead with that.
\r
145 > Some of the points in favor of upgrading automatically:
\r
147 > * cworth: "One potential concern is that [requiring manual intervention]
\r
148 > effectively breaks notmuch until the user intervenese and runs this
\r
149 > new command. So that can complicate things for any interface that sits
\r
150 > on top of notmuch."
\r
152 > * cworth: "In general, I'm often frustrated with programs that say "I
\r
153 > cannot continue until you run command <foo>.". If command <foo> needs
\r
154 > to be run, and the software knows it, why doesn't it just run it
\r
155 > itself? [...] So a message like "Run 'notmuch upgrade'" seems it could
\r
156 > corrode the user's trust in notmuch to maintain its own state."
\r
158 > * There are people who run notmuch new non-interactively. There's no
\r
159 > easy answer to handling that if manual intervention is required.
\r
161 > * It should always be okay to kill the upgrade, and continue at a later
\r
162 > time, in case it takes too long.
\r
164 > Reading the logs again, I'm not so confident about us reaching a
\r
165 > concensus. Maybe it was just me changing my mind during the course of
\r
166 > the discussion... so we can try to reach concensus here.
\r