1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D9BB0429E5A
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 17:01:36 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id r2HHxOVBLS2y for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Jun 2013 17:01:31 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D35C1431FBC
\r
21 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 17:01:30 -0700 (PDT)
\r
22 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r5301TTY025232;
\r
24 Sun, 2 Jun 2013 21:01:29 -0300
\r
25 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
26 ([156.34.82.78] helo=zancas.localnet)
\r
27 by tesseract.cs.unb.ca with esmtpsa
\r
28 (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
\r
29 (envelope-from <david@tethera.net>)
\r
30 id 1UjIDI-0002V3-Tx; Sun, 02 Jun 2013 21:01:29 -0300
\r
31 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
32 (envelope-from <david@tethera.net>)
\r
33 id 1UjIDD-0007R1-96; Sun, 02 Jun 2013 21:01:23 -0300
\r
34 From: David Bremner <david@tethera.net>
\r
35 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
36 Subject: Re: [PATCH] emacs: replace setq + let with let*
\r
37 In-Reply-To: <878v2sv2zz.fsf@qmul.ac.uk>
\r
38 References: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
39 <1370185351-23834-1-git-send-email-david@tethera.net>
\r
40 <878v2sv2zz.fsf@qmul.ac.uk>
\r
41 User-Agent: Notmuch/0.15.2+141~gd298af4 (http://notmuchmail.org) Emacs/24.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Sun, 02 Jun 2013 21:01:23 -0300
\r
44 Message-ID: <874ndgt63w.fsf@zancas.localnet>
\r
46 Content-Type: text/plain
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Mon, 03 Jun 2013 00:01:37 -0000
\r
62 Mark Walters <markwalters1009@gmail.com> writes:
\r
64 >> - (setq search (notmuch-hello-trim search))
\r
65 >> - (let ((history-delete-duplicates t))
\r
66 >> + (let* ((search (notmuch-hello-trim search))
\r
67 >> + (history-delete-duplicates t))
\r
68 >> (add-to-history 'notmuch-search-history search)))
\r
69 >> (notmuch-search search notmuch-search-oldest-first nil nil
\r
71 > These look good to me except I don't see why the above is a let* not a
\r
74 I ended up dropping this hunk because I realized it introduced a bug;
\r
75 the side-effect of the setq is needed outside the unless.
\r
77 pushed the two patches (as amended) in this thread.
\r