1 Return-Path: <racin@free.fr>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 247D5429E2C
\r
6 for <notmuch@notmuchmail.org>; Fri, 13 May 2011 15:24:51 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.001 tagged_above=-999 required=5
\r
12 tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id F96d4yfmBAwg for <notmuch@notmuchmail.org>;
\r
17 Fri, 13 May 2011 15:24:49 -0700 (PDT)
\r
18 Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 6BF5F431FD0
\r
20 for <notmuch@notmuchmail.org>; Fri, 13 May 2011 15:24:47 -0700 (PDT)
\r
21 Received: from racin (unknown [82.239.207.166])
\r
22 by smtp3-g21.free.fr (Postfix) with ESMTP id 1C5B8A61C9;
\r
23 Sat, 14 May 2011 00:24:35 +0200 (CEST)
\r
24 From: Matthieu Lemerre <racin@free.fr>
\r
25 To: Pieter Praet <pieter@praet.org>, Xavier Maillard <xma@gnu.org>,
\r
26 Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
27 Subject: Re: Warning when GMime is parsing broken email addresses
\r
28 In-Reply-To: <87r58n8nzm.fsf@praet.org>
\r
29 References: <87ipzvk2xh.fsf@free.fr> <877hai3r82.fsf@yoom.home.cworth.org>
\r
30 <m2y62vy7vy.fsf@gnu.org> <87r58n8nzm.fsf@praet.org>
\r
31 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1
\r
33 Date: Sat, 14 May 2011 00:33:31 +0200
\r
34 Message-ID: <87aaeq1b9g.fsf@free.fr>
\r
36 Content-Type: text/plain; charset=us-ascii
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Fri, 13 May 2011 22:24:51 -0000
\r
51 On Wed, 27 Apr 2011 21:59:09 +0200, Pieter Praet <pieter@praet.org> wrote:
\r
52 > On Wed, 27 Apr 2011 18:30:09 +0200, Xavier Maillard <xavier@maillard.im> wrote:
\r
53 > > On Mon, 25 Apr 2011 15:23:41 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
54 > > > On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre <racin@free.fr> wrote:
\r
55 > > > > Maybe it would also be interesting to add a warning/assertion to check
\r
56 > > > > that all email adresses added to the database are correct email
\r
57 > > > > addresses? I.e. check that the `addr' variable in _index_address_mailbox
\r
58 > > > > always has a @. This check is in fact already done using the function
\r
59 > > > > strchr, but a bad value is explicitly ignored...
\r
61 > > > Since GMime is fixed upstream (as of version 2.4.18) another option
\r
62 > > > would be to simply make the notmuch build system require a sufficiently
\r
63 > > > new version of GMime in order to build.
\r
65 > > > What do you think?
\r
69 > Unfortunately, regressions are not uncommon, and regardless, it'd be
\r
70 > nice to be notified when what we stuff in the db is not sane.
\r
72 > It would however be a good idea IMHO to check email address more
\r
73 > thorougly [1] than simply verifying whether an "@" is present.
\r
75 I agree with that, unless it is undesirable to add a dependency to a
\r
76 regex library to notmuch? If so, the @ check could still be done (and is
\r
79 I don't see the warnings either, but maybe with proper differentiation
\r
80 between stdout and stderr, I could arrange to print stderr and see the
\r
81 warning messages in emacs when I explicitely launch my mail
\r
82 synchronization script.
\r