16/ccc913cde335d1643855ae684a15012fe51e2c

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 2CCD8431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 22:59:21 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id poQUzZqZseKm for <notmuch@notmuchmail.org>;\r
  16         Wed, 28 Mar 2012 22:59:20 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 292B3431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 22:59:20 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7fbf6d0000008ba-14-4f73fa372c2b\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 43.C0.02234.73AF37F4; Thu, 29 Mar 2012 01:59:19 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q2T5xJRB010812; \r
  27         Thu, 29 Mar 2012 01:59:19 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2T5xHEM013236\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 29 Mar 2012 01:59:18 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SD8OD-0006uC-Kh; Thu, 29 Mar 2012 01:59:17 -0400\r
  37 Date: Thu, 29 Mar 2012 01:59:17 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jani Nikula <jani@nikula.org>\r
  40 Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring\r
  41 Message-ID: <20120329055917.GC2670@mit.edu>\r
  42 References: <cover.1332795415.git.jani@nikula.org>\r
  43 MIME-Version: 1.0\r
  44 Content-Type: text/plain; charset=us-ascii\r
  45 Content-Disposition: inline\r
  46 In-Reply-To: <cover.1332795415.git.jani@nikula.org>\r
  47 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IRYrdT1zX/Vexv0HNOx6JpurPF9ZszmS3e\r
  50         rJzH6sDscfjrQhaPW/dfs3s8W3WLOYA5issmJTUnsyy1SN8ugSvjz/HPTAVHWCo65/9gaWA8\r
  51         ytzFyMEhIWAi0bWCp4uRE8gUk7hwbz1bFyMXh5DAPkaJCafmM0M4Gxglnq2/ApU5ySSx4PAD\r
  52         KGcJo8Tpn0/YQPpZBFQl1jfeZAKx2QQ0JLbtX84IYosIKEpsPrkfzGYW0JdYeXImM4gtLOAg\r
  53         8aVzPwuIzSugLfHu5yWwXiEBI4lJ+74wQ8QFJU7OfMIC0aslcePfSyaQs5kFpCWW/+MACXMK\r
  54         GEs0TP4ENl5UQEViysltbBMYhWYh6Z6FpHsWQvcCRuZVjLIpuVW6uYmZOcWpybrFyYl5ealF\r
  55         ukZ6uZkleqkppZsYQYHOKcm7g/HdQaVDjAIcjEo8vKc0i/2FWBPLiitzDzFKcjApifKe+w4U\r
  56         4kvKT6nMSCzOiC8qzUktPsQowcGsJMLrfg4ox5uSWFmVWpQPk5LmYFES51XVeucnJJCeWJKa\r
  57         nZpakFoEk5Xh4FCS4K36CdQoWJSanlqRlplTgpBm4uAEGc4DNLwOpIa3uCAxtzgzHSJ/ilFR\r
  58         Spw3GCQhAJLIKM2D64UloleM4kCvCPPGglTxAJMYXPcroMFMQIOXHMkHGVySiJCSamBM/NzK\r
  59         Fxa4IPSL0rGWzwVCT74yeUisqso6enPBlSPPMyYdWNF35mferDPPXWy0a7zjs2JmbD5343Bh\r
  60         wGqhHPnzIlZ9y8vedTBdPvBsz+uK474v3/0OC7af+r9l/cTdG3jtfkop22S6ROy+MN9gxW4x\r
  61         3T8te2VrZaSMWt+xhej/9JPb8uNpvJeJEktxRqKhFnNRcSIAVVfJbh8DAAA=\r
  62 Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Thu, 29 Mar 2012 05:59:21 -0000\r
  76 \r
  77 Quoth Jani Nikula on Mar 27 at 12:04 am:\r
  78 > v3 of id:"cover.1332702915.git.jani@nikula.org" with the following\r
  79 > mostly non-functional changes:\r
  80 > \r
  81 >  - add test for the current tagging behaviour in patch 1, and change the\r
  82 >    test in patch 2 when the behaviour is changed\r
  83 >  - handle the no tag changes case in _optimize_tag_query() in patch 2\r
  84 >  - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"\r
  85 >    assignment\r
  86 >  - document the tag_query() function a bit in patch 3\r
  87 >  - make tag_message() static in patch 4\r
  88 > \r
  89 > BR,\r
  90 > Jani.\r
  91 \r
  92 LGTM.\r