1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B6072429E3B
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 03:18:55 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MkLnC6AvGm6K for <notmuch@notmuchmail.org>;
\r
16 Mon, 16 Jan 2012 03:18:55 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 03A50431FC0
\r
21 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 03:18:54 -0800 (PST)
\r
22 Received: by werh12 with SMTP id h12so1332391wer.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 03:18:53 -0800 (PST)
\r
24 Received: by 10.216.135.30 with SMTP id t30mr4824649wei.23.1326712732301;
\r
25 Mon, 16 Jan 2012 03:18:52 -0800 (PST)
\r
26 Received: from localhost ([109.131.75.86])
\r
27 by mx.google.com with ESMTPS id fg15sm21862430wbb.7.2012.01.16.03.18.51
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Mon, 16 Jan 2012 03:18:51 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH] emacs: Don't attempt to colour tags in
\r
33 `notmuch-show-mode'.
\r
34 In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org>
\r
35 References: <1325004434-24583-1-git-send-email-dme@dme.org>
\r
36 User-Agent: Notmuch/0.11+78~g6c58370 (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-unknown-linux-gnu)
\r
38 Date: Mon, 16 Jan 2012 12:17:03 +0100
\r
39 Message-ID: <87aa5nlwwg.fsf@praet.org>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Mon, 16 Jan 2012 11:18:55 -0000
\r
56 On Tue, 27 Dec 2011 16:47:14 +0000, David Edmondson <dme@dme.org> wrote:
\r
57 > The tags were coloured using text properties. Unfortunately that text
\r
58 > (the header line) also has an overlay, which overrides the text
\r
59 > properties. There's not point in applying text properties that will
\r
62 > emacs/notmuch-show.el | 8 ++------
\r
63 > 1 files changed, 2 insertions(+), 6 deletions(-)
\r
65 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
66 > index 8c9d846..24f0b40 100644
\r
67 > --- a/emacs/notmuch-show.el
\r
68 > +++ b/emacs/notmuch-show.el
\r
69 > @@ -221,10 +221,7 @@ indentation."
\r
70 > (goto-char (notmuch-show-message-top))
\r
71 > (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t)
\r
72 > (let ((inhibit-read-only t))
\r
73 > - (replace-match (concat "("
\r
74 > - (propertize (mapconcat 'identity tags " ")
\r
75 > - 'face 'notmuch-tag-face)
\r
77 > + (replace-match (concat "(" (mapconcat 'identity tags " ") ")"))))))
\r
79 > (defun notmuch-show-clean-address (address)
\r
80 > "Try to clean a single email ADDRESS for display. Return
\r
81 > @@ -278,8 +275,7 @@ message at DEPTH in the current thread."
\r
85 > - (propertize (mapconcat 'identity tags " ")
\r
86 > - 'face 'notmuch-tag-face)
\r
87 > + (mapconcat 'identity tags " ")
\r
89 > (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face)))
\r
94 Alas, those text properties actually *were* effective (and I liked them :)
\r
96 - Before: http://i.imgur.com/Ipxnm.png
\r
97 - After: http://i.imgur.com/XcaaF.png
\r