1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2369C431FC0
\r
6 for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 08:16:50 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id os4WGzhm1RbQ for <notmuch@notmuchmail.org>;
\r
17 Tue, 30 Jul 2013 08:16:44 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 07A92431FBF
\r
22 for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 08:16:44 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1V4BfB-0007Z5-E3; Tue, 30 Jul 2013 16:16:42 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1V4BfB-0000QB-38; Tue, 30 Jul 2013 16:16:37 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: notmuch@notmuchmail.org
\r
33 Subject: Re: bug in attachment handling
\r
34 In-Reply-To: <87ppu0t7yf.fsf@qmul.ac.uk>
\r
35 References: <87ppu0t7yf.fsf@qmul.ac.uk>
\r
36 User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/24.2.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Tue, 30 Jul 2013 16:16:36 +0100
\r
39 Message-ID: <87li4om623.fsf@qmul.ac.uk>
\r
41 Content-Type: text/plain
\r
42 X-Sender-Host-Address: 93.97.24.31
\r
43 X-QM-SPAM-Info: Sender has good ham record. :)
\r
44 X-QM-Body-MD5: ebe7b1d742724dfbe7e6d8e51dc3a129 (of first 20000 bytes)
\r
45 X-SpamAssassin-Score: 0.0
\r
46 X-SpamAssassin-SpamBar: /
\r
47 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
49 spam. We require at least 5.0 points to mark a message as spam.
\r
50 This message scored 0.0 points. Summary of the scoring:
\r
51 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
52 provider * (markwalters1009[at]gmail.com)
\r
53 * 0.0 AWL AWL: From: address is in the auto white-list
\r
54 X-QM-Scan-Virus: ClamAV says the message is clean
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Tue, 30 Jul 2013 15:16:50 -0000
\r
71 On Tue, 30 Jul 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
74 > I have been seeing a bug in attachment handling in recent notmuch. If a
\r
75 > pdf part is sent as application/octet-stream then notmuch says
\r
76 > [[file.pdf: application/octet-stream (as application/pdf) ] but when
\r
77 > viewing it with . v or the default button action (when customised to
\r
78 > view) it treats it as application/octet-stream.
\r
80 > I think this is a regression but haven't checked yet: it probably has a
\r
81 > simple fix so we may want to fix it before 0.16 (users may be grumpy
\r
82 > about the key binding changes etc as it is!)
\r
84 > I attach a pdf with this message (just a mozilla print-to-file of the
\r
85 > notmuch webpage) which should demonstrate the problem.
\r
87 I have now checked that it is a regression: 0.15 is fine and git bisect
\r
88 gives the first bad commit as 1546387d723ec47cd281f3c2bf6da2fddf18c045.
\r
90 The problem comes because we used to store the content-type with the
\r
91 button: it was called content-type but in the function
\r
92 notmuch-show-insert-part-header this was the "calculated content-type"
\r
93 (with declared-type being the originally declared type).
\r
95 Elsewhere though content-type is used for the original declared-type
\r
96 including where the version post 1546 above picks it up (in
\r
97 notmuch-show-current-part-handle).
\r
99 So somehow we need to get the calculated content-type into that
\r
100 function. I am not sure what the cleanest way to do that is so will
\r
101 just post this for now.
\r